Re: [PATCH 5/9] xfs: fix split buffer vector log recovery support

Mark Tinguely
2013-05-29T19:21:54Z

On 05/27/13 01:38, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> A long time ago in a galaxy far away....
>
> .. the was a commit made to fix some ilinux specific "fragmented
> buffer" log recovery problem:
>
> http://oss.sgi.com/cgi-bin/gitweb.cgi?p=archive/xfs-import.git;a=commitdiff;h=b29c0bece51da72fb3ff3b61391a391ea54e1603
>
> That problem occurred when a contiguous dirty region of a buffer was
> split across across two pages of an unmapped buffer. It's been a
> long time since that has been done in XFS, and the changes to log
> the entire inode buffers for CRC enabled filesystems has
> re-introduced that corner case.
>
> And, of course, it turns out that the above commit didn't actually
> fix anything - it just ensured that log recovery is guaranteed to
> fail when this situation occurs. And now for the gory details.
>
...

Thanks for the great walk through of the problem.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>