Re: [PATCH 4/9] xfs: rework dquot CRCs

Dave Chinner
2013-05-30T01:00:40Z

On Wed, May 29, 2013 at 02:58:27PM -0400, Brian Foster wrote:
> On 05/27/2013 02:38 AM, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Calculating dquot CRCs when the backing buffer is written back just
> > doesn't work reliably. There are several places which manipulate
> > dquots directly in the buffers, and they don't calculate CRCs
> > appropriately, nor do they always set the buffer up to calculate
> > CRCs appropriately.
> >
> > Firstly, if we log a dquot buffer (e.g. during allocation) it gets
> > logged without valid CRC, and so on recovery we end up with a dquot
> > that is not valid.
> >
> > Secondly, if we recover/repair a dquot, we don't have a verifier
> > attached to the buffer and hence CRCs arenot calculate don the way
> > down to disk.
> >
> > Thirdly, calculating the CRC after we've changed the contents means
> > that if we re-read the dquot from the buffer, we cannot verify the
> > contents of the dquot are valid, as the CRC is invalid.
> >
> > So, to avoid all the dquot CRC errors that are being detected by the
> > read verifier, change to using the same model as for inodes. that
> > is, dquot CRCs are calculated and written to the backing buffer at
> > the time the dquot is flushed to the backing buffer. If we modify
> > the dquuot directly in the backing buffer, calculate the CRC
> > immediately after the modification is complete. Hence the dquot in
> > the on-disk buffer should always have a valid CRC.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > fs/xfs/xfs_dquot.c | 37 ++++++++++++++++---------------------
> > fs/xfs/xfs_log_recover.c | 10 ++++++++++
> > fs/xfs/xfs_qm.c | 36 ++++++++++++++++++++++++++----------
> > fs/xfs/xfs_quota.h | 2 ++
> > 4 files changed, 54 insertions(+), 31 deletions(-)
> >
> ...
> > diff --git a/fs/xfs/xfs_qm.c b/fs/xfs/xfs_qm.c
> > index f41702b..d181542 100644
> > --- a/fs/xfs/xfs_qm.c
> > +++ b/fs/xfs/xfs_qm.c
> > @@ -41,6 +41,7 @@
> > #include "xfs_qm.h"
> > #include "xfs_trace.h"
> > #include "xfs_icache.h"
> > +#include "xfs_cksum.h"
> >
> > /*
> > * The global quota manager. There is only one of these for the entire
> > @@ -839,7 +840,7 @@ xfs_qm_reset_dqcounts(
> > xfs_dqid_t id,
> > uint type)
> > {
> > - xfs_disk_dquot_t *ddq;
> > + struct xfs_dqblk *dqb;
> > int j;
> >
> > trace_xfs_reset_dqcounts(bp, _RET_IP_);
> > @@ -853,8 +854,12 @@ xfs_qm_reset_dqcounts(
> > do_div(j, sizeof(xfs_dqblk_t));
> > ASSERT(mp->m_quotainfo->qi_dqperchunk == j);
> > #endif
> > - ddq = bp->b_addr;
> > + dqb = bp->b_addr;
> > for (j = 0; j < mp->m_quotainfo->qi_dqperchunk; j++) {
> > + struct xfs_disk_dquot *ddq;
> > +
> > + ddq = (struct xfs_disk_dquot *)&dqb[j];
> > +
> > /*
> > * Do a sanity check, and if needed, repair the dqblk. Don't
> > * output any warnings because it's perfectly possible to
> > @@ -871,7 +876,8 @@ xfs_qm_reset_dqcounts(
> > ddq->d_bwarns = 0;
> > ddq->d_iwarns = 0;
> > ddq->d_rtbwarns = 0;
> > - ddq = (xfs_disk_dquot_t *) ((xfs_dqblk_t *)ddq + 1);
> > + xfs_update_cksum((char *)&dqb[j], sizeof(struct xfs_dqblk),
> > + XFS_DQUOT_CRC_OFF);
>
> Nice cleanup on the cast ugliness even without the crc change. Is there
> a technical reason for the unconditional crc update here beyond that
> we're doing a reset? I'm wondering if there's any value in leaving those
> bits untouched for a filesystem that might have never enabled crc
> (quotacheck or not).

The dquot might be zeroed and unused, but the buffer it sits in is
still allocated and valid. That means if we ever start using that
dquot again (either by quotacheck or a new uid/gid/prid), it will be
read straight out of the buffer rather than allocated, and hence the
constraint that allocated but unused dquots still need to have valid
CRCs.

FWIW, the dquot buffer read validates the CRC on all dquots in the
buffer when it comes off disk as it has no way of knowing what
dquots contain valid data or not. Same with the xfs_qm_dqcheck()
call - an unused dquot still needs to be a valid dquot to pass those
checks...

> FWIW, the rest of this patch looks sane to me (I'm less familiar with
> the log recovery code, but the changes seem isolated and
> straightforward) and I couldn't locate anywhere else we modify the
> backing buffer for the dquot.

Right, apart from dquot allocation and flushing, there aren't any.
Resetting the dquots to zero before a quota check is a special case.
Doing it via the buffer avoids needing to initialise all the dquots
in memory that *might* be tracked by the quota file. But we don't
know what quota IDs are tracked in the quota file with first mapping
the quota file and finding all the offsets that contain blocks. And,
well, once we have that mapping, why would be do N xfs_qm_dqget()
calls per buffer to get initialised, cached dquots from the buffer
when we can simply RMW the buffers we've mapped directly?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com