Re: [PATCH 1/9] xfs: don't emit v5 superblock warnings on write

Dave Chinner
2013-06-11T06:05:54Z

On Thu, May 30, 2013 at 12:49:15PM -0500, Ben Myers wrote:
> On Wed, May 29, 2013 at 12:39:11PM -0400, Brian Foster wrote:
> > On 05/27/2013 02:38 AM, Dave Chinner wrote:
> > > From: Dave Chinner <dchinner@redhat.com>
> > >
> > > We write the superblock every 30s or so which results in the
> > > verifier being called. Right now that results in this output
> > > every 30s:
> > >
> > > XFS (vda): Version 5 superblock detected. This kernel has EXPERIMENTAL support enabled!
> > > Use of these features in this kernel is at your own risk!
> > >
> > > And spamming the logs.
> > >
> > > We don't need to check for whether we support v5 superblocks or
> > > whether there are feature bits we don't support set as these are
> > > only relevant when we first mount the filesytem. i.e. on superblock
> > > read. Hence for the write verification we can just skip all the
> > > checks (and hence verbose output) altogether.
> > >
> > > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > > ---
> >
> > Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> Applied.

Ben, while I see this in the xfsdev tree, I don't see it in Linus'
tree. Did it get missed on the recent merges? If so, can you queue
it up for 3.10-rc6?

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com