From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id 58E7B7F3F for ; Thu, 30 May 2013 16:21:52 -0500 (CDT) Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by relay1.corp.sgi.com (Postfix) with ESMTP id 486308F8033 for ; Thu, 30 May 2013 14:21:49 -0700 (PDT) Received: from mx2.suse.de (cantor2.suse.de [195.135.220.15]) by cuda.sgi.com with ESMTP id B6BCE8jTmEnCp3uf for ; Thu, 30 May 2013 14:21:48 -0700 (PDT) From: Jan Kara Subject: [PATCH 1/3 v2] 285: Fix test for ext4 in some configurations Date: Thu, 30 May 2013 23:21:43 +0200 Message-Id: <1369948905-6693-1-git-send-email-jack@suse.cz> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: linux-ext4@vger.kernel.org, Jan Kara In some configurations (e.g. 1 KB block size), ext4 can decide it is better to zero out several blocks rather than splitting unwritten extent. This changes results SEEK_HOLE / SEEK_DATA returns and thus the test fails. Fix the problem by disabling the feature for this test. Reviewed-by: Eric Sandeen Signed-off-by: Jan Kara --- tests/generic/285 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/generic/285 b/tests/generic/285 index b700a15..8078b1c 100755 --- a/tests/generic/285 +++ b/tests/generic/285 @@ -46,6 +46,12 @@ BASE_TEST_FILE=$TEST_DIR/seek_sanity_testfile [ -x $here/src/seek_sanity_test ] || _notrun "seek_sanitfy_tester not built" +# Disable extent zeroing for ext4 as that change where holes are created +if [ "$FSTYP" = "ext4" ]; then + DEV=`basename $TEST_DEV` + echo 0 >/sys/fs/ext4/$DEV/extent_max_zeroout_kb +fi + _cleanup() { eval "rm -f $BASE_TEST_FILE.*" -- 1.8.1.4 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs