Re: [PATCH 06/60] xfs: xfs_ifree doesn't need to modify the inode buffer

Mark Tinguely
2013-06-21T21:24:28Z

On 06/18/13 23:50, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> Long ago, bulkstat used to read inodes directly fromteh backing
> buffer for speed. This had the unfortunate problem of being cache
> incoherent with unlinks, and so xfs_ifree() had to mark the inode
> as free directly in the backing buffer. bulkstat was changed some
> time ago to use inode cache coherent lookups, and so will never see
> unlinked inodes in it's lookups. Hence xfs_ifree() does not need to
> touch the inode backing buffer anymore.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
> fs/xfs/xfs_inode.c | 32 ++++----------------------------

looks good.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>