From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 15/15] xfs: implement inode change count
Date: Fri, 28 Jun 2013 11:07:11 -0500 [thread overview]
Message-ID: <1372435631.8341.114.camel@chandra-dt.ibm.com> (raw)
In-Reply-To: <1372313099-8121-16-git-send-email-david@fromorbit.com>
On Thu, 2013-06-27 at 16:04 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> For CRC enabled filesystems, add support for the monotonic inode
> version change counter that is needed by protocols like NFSv4 for
> determining if the inode has changed in any way at all between two
> unrelated operations on the inode.
>
> This bumps the change count the first time an inode is dirtied in a
> transaction. Since all modifications to the inode are logged, this
> will catch all changes that are made to the inode, including
> timestamp updates that occur during data writes.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
> ---
> fs/xfs/xfs_super.c | 4 ++++
> fs/xfs/xfs_trans_inode.c | 11 +++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f59e27f..a1587f9 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1482,6 +1482,10 @@ xfs_fs_fill_super(
> sb->s_time_gran = 1;
> set_posix_acl_flag(sb);
>
> + /* version 5 superblocks support inode version counters. */
> + if (XFS_SB_VERSION_NUM(&mp->m_sb) == XFS_SB_VERSION_5)
> + sb->s_flags |= MS_I_VERSION;
> +
> error = xfs_mountfs(mp);
> if (error)
> goto out_filestream_unmount;
> diff --git a/fs/xfs/xfs_trans_inode.c b/fs/xfs/xfs_trans_inode.c
> index ac6d567..53dfe46 100644
> --- a/fs/xfs/xfs_trans_inode.c
> +++ b/fs/xfs/xfs_trans_inode.c
> @@ -112,6 +112,17 @@ xfs_trans_log_inode(
> ASSERT(ip->i_itemp != NULL);
> ASSERT(xfs_isilocked(ip, XFS_ILOCK_EXCL));
>
> + /*
> + * First time we log the inode in a transaction, bump the inode change
> + * counter if it is configured for this to occur.
> + */
> + if (!(ip->i_itemp->ili_item.li_desc->lid_flags & XFS_LID_DIRTY) &&
> + IS_I_VERSION(VFS_I(ip))) {
> + inode_inc_iversion(VFS_I(ip));
> + ip->i_d.di_changecount = VFS_I(ip)->i_version;
> + flags |= XFS_ILOG_CORE;
> + }
> +
> tp->t_flags |= XFS_TRANS_DIRTY;
> ip->i_itemp->ili_item.li_desc->lid_flags |= XFS_LID_DIRTY;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-06-28 16:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-27 6:04 [PATCH 00/15] xfs: patchset for 3.11 Dave Chinner
2013-06-27 6:04 ` [PATCH 01/15] xfs: update mount options documentation Dave Chinner
2013-06-27 14:48 ` Ben Myers
2013-06-27 19:08 ` Ben Myers
2013-06-28 2:09 ` Dave Chinner
2013-06-28 2:32 ` Dave Chinner
2013-06-28 15:39 ` Geoffrey Wehrman
2013-06-28 16:49 ` Eric Sandeen
2013-06-28 19:58 ` Geoffrey Wehrman
2013-06-28 17:27 ` Ric Wheeler
2013-06-28 19:39 ` Ben Myers
2013-06-29 2:38 ` Dave Chinner
2013-06-28 2:18 ` Eric Sandeen
2013-06-28 20:46 ` Ben Myers
2013-06-27 6:04 ` [PATCH 02/15] xfs: add pluging for bulkstat readahead Dave Chinner
2013-06-27 6:04 ` [PATCH 03/15] xfs: plug directory buffer readahead Dave Chinner
2013-06-27 6:04 ` [PATCH 04/15] xfs: don't use speculative prealloc for small files Dave Chinner
2013-06-27 6:04 ` [PATCH 05/15] xfs: don't do IO when creating an new inode Dave Chinner
2013-06-27 6:04 ` [PATCH 06/15] xfs: xfs_ifree doesn't need to modify the inode buffer Dave Chinner
2013-06-27 6:04 ` [PATCH 07/15] xfs: Introduce ordered log vector support Dave Chinner
2013-06-27 6:04 ` [PATCH 08/15] xfs: Introduce an ordered buffer item Dave Chinner
2013-06-27 6:04 ` [PATCH 09/15] xfs: Inode create log items Dave Chinner
2013-06-27 6:04 ` [PATCH 10/15] xfs: Inode create transaction reservations Dave Chinner
2013-06-27 6:04 ` [PATCH 11/15] xfs: Inode create item recovery Dave Chinner
2013-06-27 6:04 ` [PATCH 12/15] xfs: Use inode create transaction Dave Chinner
2013-06-27 6:04 ` [PATCH 13/15] xfs: remove local fork format handling from xfs_bmapi_write() Dave Chinner
2013-06-27 6:04 ` [PATCH 14/15] xfs: dquot log reservations are too small Dave Chinner
2013-06-27 14:38 ` Mark Tinguely
2013-06-28 17:18 ` Chandra Seetharaman
2013-06-29 2:42 ` Dave Chinner
2013-07-09 19:31 ` Ben Myers
2013-07-09 20:39 ` Dave Chinner
2013-07-09 20:42 ` Ben Myers
2013-06-27 6:04 ` [PATCH 15/15] xfs: implement inode change count Dave Chinner
2013-06-27 15:06 ` Mark Tinguely
2013-06-28 16:07 ` Chandra Seetharaman [this message]
2013-06-28 18:00 ` Ben Myers
2013-06-27 19:48 ` [PATCH 00/15] xfs: patchset for 3.11 Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1372435631.8341.114.camel@chandra-dt.ibm.com \
--to=sekharan@us.ibm.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox