public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: xfs@oss.sgi.com
Cc: David Sterba <dsterba@suse.cz>
Subject: [PATCH] xfstests: skip generic/192 if noatime is set
Date: Wed,  3 Jul 2013 16:00:05 +0200	[thread overview]
Message-ID: <1372860005-1016-1-git-send-email-dsterba@suse.cz> (raw)

Test generic/192 fails if noatime is set

generic/192
    -delta1 - access time after sleep in-core: 40
    -delta2 - access time after sleep on-disk: 40
    +delta1 - access time after sleep in-core: 0
    +delta2 - access time after sleep on-disk: 0

but it's pointless to test atime effects with noatime.

Signed-off-by: David Sterba <dsterba@suse.cz>
---
 tests/generic/192 | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/tests/generic/192 b/tests/generic/192
index a40c121..2b4e41c 100755
--- a/tests/generic/192
+++ b/tests/generic/192
@@ -38,6 +38,13 @@ _access_time()
 	stat --format=%X $1
 }
 
+is_noatime_set() {
+	case "$MOUNT_OPTIONS" in
+		*noatime*) return 0;;
+	esac
+	return 1
+}
+
 # get standard environment, filters and checks
 . ./common/rc
 . ./common/filter
@@ -52,6 +59,10 @@ _supported_os Linux
 #delay=45
 delay=40
 
+if is_noatime_set; then
+	_notrun "this test makes no sense with noatime"
+fi
+
 testfile=$TEST_DIR/testfile
 rm -f $testfile
 rm -f $seqres.full
-- 
1.8.2

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-07-03 14:00 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-03 14:00 David Sterba [this message]
2013-07-19 20:50 ` [PATCH] xfstests: skip generic/192 if noatime is set Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1372860005-1016-1-git-send-email-dsterba@suse.cz \
    --to=dsterba@suse.cz \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox