***** SUSPECTED SPAM ***** Re: [PATCH 28/49] xfs: move unrealted definitions out of xfs_inode.h

Dave Chinner
2013-08-12T00:30:46Z

On Mon, Aug 05, 2013 at 04:57:11PM -0500, Mark Tinguely wrote:
> On 07/19/13 01:45, Dave Chinner wrote:
> >From: Dave Chinner<dchinner@redhat.com>
> >
> >Signed-off-by: Dave Chinner<dchinner@redhat.com>
> >---
>
>
> >diff --git a/include/xfs_trans.h b/include/xfs_trans.h
> >index e504103..37aca08 100644
> >--- a/include/xfs_trans.h
> >+++ b/include/xfs_trans.h
> >@@ -89,6 +89,13 @@ struct xfs_log_item_desc {
> > #define XFS_ATTR_BTREE_REF 1
> > #define XFS_DQUOT_REF 1
> >
> >+/*
> >+ * Flags for xfs_trans_ichgtime().
> >+ */
> >+#define XFS_ICHGTIME_MOD 0x1 /* data fork modification timestamp */
> >+#define XFS_ICHGTIME_CHG 0x2 /* inode field change timestamp */
> >+#define XFS_ICHGTIME_CREATE 0x4 /* inode create timestamp */
> >+
>
> in the kernel patch 13/49 these entries go into xfs_log_format.h

Right, in the updated kernel series xfs_trans.h is no longer shared
with userspace, and this patch series doesn't reflect that. it needs
updating.

> > #ifdef __KERNEL__
> >
> > struct xfs_buf;
> >diff --git a/libxfs/xfs.h b/libxfs/xfs.h
> >index 7149c09..1a01c61 100644
> >--- a/libxfs/xfs.h
> >+++ b/libxfs/xfs.h
> >@@ -68,6 +68,9 @@ typedef __uint32_t inst_t; /* an instruction */
> >
> > #define IHOLD(ip) ((void) 0)
> >
> >+#define XFS_IGET_CREATE 0x1
> >+#define XFS_IGET_UNTRUSTED 0x2
> >+
> > /* stop unused var warnings by assigning mp to itself */
> > #define XFS_CORRUPTION_ERROR(e,l,mp,m) do { \
> > (mp) = (mp); \
>
> in the kernel patch 13/49 these entries go into xfs_icache.h

Yup, they go into a kernel only header file. Userspace can define
them how they want as xfs_iget() has different requirements and a
completely different implementation in userspace.

>
> --Mark.
>

--
Dave Chinner
david@fromorbit.com