From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 06/10 v2] xfstests: Allow to specify RESULT_BASE directory
Date: Fri, 02 Aug 2013 18:51:52 -0500 [thread overview]
Message-ID: <1375487512.4155.73.camel@chandra-dt.ibm.com> (raw)
In-Reply-To: <1373539085-8577-7-git-send-email-lczerner@redhat.com>
On Thu, 2013-07-11 at 12:38 +0200, Lukas Czerner wrote:
> This commit adds the possibility to specify RESULT_BASE directory from
> the config file, or with environment variable. The default remains the
> same "$here/results/".
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
> ---
> check | 1 -
> common/config | 5 +++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/check b/check
> index dc972d7..428eba1 100755
> --- a/check
> +++ b/check
> @@ -66,7 +66,6 @@ export FSTYP
> SUPPORTED_TESTS="[0-9][0-9][0-9] [0-9][0-9][0-9][0-9]"
> SRC_GROUPS="generic shared"
> export SRC_DIR="tests"
> -export RESULT_BASE=${RESULT_BASE:="$here/results"}
>
> usage()
> {
> diff --git a/common/config b/common/config
> index 34c99e1..39dd469 100644
> --- a/common/config
> +++ b/common/config
> @@ -230,6 +230,11 @@ if [ -f "$HOST_OPTIONS" ]; then
> fi
>
> get_next_config() {
> + # set default RESULT_BASE
> + if [ -z "$RESULT_BASE" ]; then
> + export RESULT_BASE="$here/results/"
> + fi
> +
> # Mandatory Config values.
> MC=""
> [ -z "$EMAIL" ] && MC="$MC EMAIL"
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-08-02 23:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-11 10:37 [RFC][PATCH 00/10 v2] xfstests: Add support for config section Lukas Czerner
2013-07-11 10:37 ` [PATCH 01/10 v2] xfstests: Run all tests when nothing is specified Lukas Czerner
2013-08-02 23:48 ` Chandra Seetharaman
2013-10-16 19:36 ` Rich Johnston
2013-07-11 10:37 ` [PATCH 02/10 v2] xfstests: Export all important variables in common/config Lukas Czerner
2013-08-02 23:49 ` Chandra Seetharaman
2013-07-11 10:37 ` [PATCH 03/10 v2] xfstests: Refactor code for obtaining test list Lukas Czerner
2013-08-02 23:49 ` Chandra Seetharaman
2013-07-11 10:37 ` [PATCH 04/10 v2] xfstests: Allow to recheck options in common/rc Lukas Czerner
2013-08-02 23:50 ` Chandra Seetharaman
2013-07-11 10:38 ` [PATCH 05/10 v2] xfstests: Allow to re-read configuration Lukas Czerner
2013-08-02 23:51 ` Chandra Seetharaman
2013-07-11 10:38 ` [PATCH 06/10 v2] xfstests: Allow to specify RESULT_BASE directory Lukas Czerner
2013-08-02 23:51 ` Chandra Seetharaman [this message]
2013-07-11 10:38 ` [PATCH 07/10 v2] xfstests: Prepare for config section Lukas Czerner
2013-08-02 23:53 ` Chandra Seetharaman
2013-07-11 10:38 ` [PATCH 08/10 v2] xfstests: Add support for sections in config file Lukas Czerner
2013-08-03 0:05 ` Chandra Seetharaman
2013-07-11 10:38 ` [PATCH 09/10 v2] xfstests: Allow to recreate TEST_DEV Lukas Czerner
2013-08-03 0:13 ` Chandra Seetharaman
2013-07-11 10:38 ` [PATCH 10/10 v2] xfstests: Remount file system if MOUNT_OPTIONS changed Lukas Czerner
2013-08-03 0:14 ` Chandra Seetharaman
2013-10-16 20:51 ` Rich Johnston
2013-10-17 10:49 ` [PATCH 10/10 v2] xfstests: Remount file system if MOUNT_OPTIONS changedx Lukáš Czerner
2013-08-16 15:43 ` [RFC][PATCH 00/10 v2] xfstests: Add support for config section Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375487512.4155.73.camel@chandra-dt.ibm.com \
--to=sekharan@us.ibm.com \
--cc=lczerner@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox