From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 3/3] xfstests: Make 204 work with different block and inode sizes.
Date: Tue, 3 Sep 2013 10:14:55 +1000 [thread overview]
Message-ID: <1378167295-7566-4-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1378167295-7566-1-git-send-email-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
Otherwise it fails with ENOSPC on CRC enabled filesystems because
ofhte larger inode size.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
common/filter | 10 +++++++++-
tests/generic/204 | 34 ++++++++++++++++++++++++++++++----
2 files changed, 39 insertions(+), 5 deletions(-)
diff --git a/common/filter b/common/filter
index ee738ca..dc9e197 100644
--- a/common/filter
+++ b/common/filter
@@ -131,9 +131,17 @@ _filter_date()
}
# prints filtered output on stdout, values (use eval) on stderr
-#
+# Non XFS filesystems always return a 4k block size and a 256 byte inode.
_filter_mkfs()
{
+ case $FSTYP in
+ xfs)
+ ;;
+ *)
+ perl -e 'print STDERR "dbsize=4096\nisize=256\n"'
+ return ;;
+ esac
+
set -
perl -ne '
if (/^meta-data=([\w,|\/.-]+)\s+isize=(\d+)\s+agcount=(\d+), agsize=(\d+) blks/) {
diff --git a/tests/generic/204 b/tests/generic/204
index a054c8f..598b805 100755
--- a/tests/generic/204
+++ b/tests/generic/204
@@ -28,6 +28,12 @@ echo "QA output created by $seq"
here=`pwd`
tmp=/tmp/$$
status=1 # failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+ rm -f $tmp.*
+}
# get standard environment, filters and checks
. ./common/rc
@@ -41,15 +47,35 @@ _require_scratch
rm -f $seqres.full
+# get the block size first
+_scratch_mkfs 2> /dev/null | _filter_mkfs 2> $tmp.mkfs > /dev/null
+. $tmp.mkfs
+
SIZE=`expr 104 \* 1024 \* 1024`
-_scratch_mkfs_sized $SIZE &> /dev/null
+_scratch_mkfs_sized $SIZE $dbsize 2> /dev/null \
+ | _filter_mkfs 2> $tmp.mkfs > /dev/null
_scratch_mount
+. $tmp.mkfs
+
# fix the reserve block pool to a known size so that the enospc calculations
-# work out correctly.
-_scratch_resvblks 1024 >> $seqres.full 2>&1
+# work out correctly. Space usages is based 22500 files and 1024 reserved blocks
+# on a 4k block size 256 byte inode size filesystem.
+resv_blks=1024
+space=97920000
+
+# decrease files for inode size.
+# 22500 * (256 + 4k) = ~97MB
+# files * (isize + bsize) = 97MB
+# files = (97920000 / (isize + bsize))
+
+files=$((space / (isize + dbsize)))
+resv_blks=$((resv_blks * (4096 / dbsize)))
+
+echo files $files, resvblks $resv_blks >> $seqres.full
+_scratch_resvblks $resv_blks >> $seqres.full 2>&1
-for i in `seq 1 22500`; do
+for i in `seq 1 $files`; do
echo -n > $SCRATCH_MNT/$i
echo XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX > $SCRATCH_MNT/$i
done
--
1.8.3.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-09-03 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-03 0:14 [PATCH 0/3] xfstests: improvements for generic/204 Dave Chinner
2013-09-03 0:14 ` [PATCH 1/3] xfstests: generic/204 should call _check_scratch_fs Dave Chinner
2013-09-03 7:33 ` Christoph Hellwig
2013-09-03 0:14 ` [PATCH 2/3] xfstests: Obey mkfs options for sized filesystems on XFS Dave Chinner
2013-09-03 7:34 ` Christoph Hellwig
2013-09-03 0:14 ` Dave Chinner [this message]
2013-10-14 13:10 ` [PATCH 3/3] xfstests: Make 204 work with different block and inode sizes Rich Johnston
2013-10-14 13:09 ` [PATCH 0/3] xfstests: improvements for generic/204 Rich Johnston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378167295-7566-4-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox