Re: [PATCH 31/55 V2] libxfs: switch over to xfs_sb.c and remove xfs_mount.c

Mark Tinguely
2013-09-10T14:11:46Z

On 09/09/13 20:02, Dave Chinner wrote:
> diff --git a/include/xfs_sb.h b/include/xfs_sb.h
> index 4a710d6..04fe32a 100644
> --- a/include/xfs_sb.h
> +++ b/include/xfs_sb.h
> @@ -26,6 +26,7 @@
>
> struct xfs_buf;
> struct xfs_mount;
> +struct xfs_trans;
>
> #define XFS_SB_MAGIC 0x58465342 /* 'XFSB' */
> #define XFS_SB_VERSION_1 1 /* 5.3, 6.0.1, 6.1 */
> @@ -630,6 +631,12 @@ static inline int xfs_sb_version_has_pquotino(xfs_sb_t *sbp)
> return XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5;
> }
>
> +static inline bool
> +xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino)
> +{
> + return (ino == sbp->sb_uquotino || ino == sbp->sb_gquotino);
> +}
> +
> /*

Thanks Dave for doing all this work.

The current kernel xfs_sb.h has an additional
" || ino == sbp->sb_pquotino"
from kernel commit d892d586 that is not making it into user xfs_sb.h.

It is wrong to add it here but in a follow up patch (Chandra?).

I am happy with the kernel / user sync series.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>