Re: [PATCH 31/55] libxfs: switch over to xfs_sb.c and remove xfs_mount.c

Mark Tinguely
2013-09-06T21:43:23Z

On 09/06/13 16:40, Dave Chinner wrote:
> On Fri, Sep 06, 2013 at 01:15:38PM -0500, Mark Tinguely wrote:
>> On 09/04/13 17:05, Dave Chinner wrote:
>>> From: Dave Chinner<dchinner@redhat.com>
>>>
>>> Now that the kernel code has split the superblock specific code out
>>> of xfs_mount.c, we don't need xfs_mount.c anymore. Copy in xfs_sb.c
>>> and remove xfs_mount.c
>>>
>>> Signed-off-by: Dave Chinner<dchinner@redhat.com>
>>> ---
>>
>> user equivalent of the for Linux 3.12 kernel patch 20/49.
>> This patch leaves xfs_sb.c/xfs_sb.h difference.
>>
>> For example in xfs_sb.h the user header is missing the project inode
>> test in xfs_is_quota_inode().
>>
>> Shouldn't xfs_sb.[ch] synced to the kernel files at this point?
>
> No, they don't end up perfectly synced because of the different
> error messages in the code and some of the checks aren't relevant to
> userspace. Looks like there's some new whitespace differences, and
> that I missed a pquota change as well. I'll send a new version later
> today.
>
> Cheers,
>
> Dave.

Okay. Thanks for the work. We can bring that series in early next week.

--Mark.