[PATCH] xfsprogs: fix potential memory leak in repare/sb.c

* [PATCH] xfsprogs: fix potential memory leak in repare/sb.c
@ 2013-09-18  9:40 Li Zhong
  2013-09-18 16:26 ` Mark Tinguely
  2013-10-18 16:35 ` Rich Johnston
  0 siblings, 2 replies; 3+ messages in thread
From: Li Zhong @ 2013-09-18  9:40 UTC (permalink / raw)
  To: xfsprogs; +Cc: Chandra Seetharaman

Following Resource leak is reported by coverity:
  
CID 997011 (#1 of 1): Resource leak (RESOURCE_LEAK)6. leaked_storage:
Variable "buf" going out of scope leaks the storage it points to.
505                return(XR_EOF);

Add a free(buf) to solve it. 

Signed-off-by: Li Zhong <zhong@linux.vnet.ibm.com>
---
 repair/sb.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/repair/sb.c b/repair/sb.c
index e2f5933..aa550e3 100644
--- a/repair/sb.c
+++ b/repair/sb.c
@@ -502,6 +502,7 @@ get_sb(xfs_sb_t *sbp, xfs_off_t off, int size, xfs_agnumber_t agno)
 		do_warn(
 	_("error reading superblock %u -- seek to offset %" PRId64 " failed\n"),
 			agno, off);
+		free(buf);
 		return(XR_EOF);
 	}
 



_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 3+ messages in thread