Re: [PATCH 04/16] xfs: decouple log and transaction headers

Dave Chinner
2013-10-04T00:49:56Z

On Thu, Oct 03, 2013 at 07:56:50AM -0700, Christoph Hellwig wrote:
> > @@ -33,16 +33,6 @@ struct xfs_log_vec {
> > #define XFS_LOG_VEC_ORDERED (-1)
> >
> > /*
> > - * Structure used to pass callback function and the function's argument
> > - * to the log manager.
> > - */
> > -typedef struct xfs_log_callback {
> > - struct xfs_log_callback *cb_next;
> > - void (*cb_func)(void *, int);
> > - void *cb_arg;
> > -} xfs_log_callback_t;
> > -
> > -/*
>
> Looking at the code I don't think this one needs to be moved as the
> t_logcb field in struct xfs_trans is dead already. Just remove it in
> a separate patch and this declaration can stay where it is.

Ok, I debated whether to just remove the t_logcb fields, and decided
just to move the declaration on the toss of a coin. I'll just remove
it...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com