Re: [PATCH 05/16] xfs: decouple inode and bmap btree header files

Christoph Hellwig
2013-10-15T19:06:25Z

On Fri, Oct 04, 2013 at 11:00:09AM +1000, Dave Chinner wrote:
> On Thu, Oct 03, 2013 at 07:58:49AM -0700, Christoph Hellwig wrote:
> > I like this a lot, but it also seems to move the in-core btree records
> > and keys to the format header which seems wrong. Maybe those should be
> > centralized in xfs_btree.h instead?
>
> Which structures are you talking about here? there's so many key and
> pointer definitions I'm not sure if there's a specific one you had
> in mind or whether you mean "all of them"...
>
> Keep in mind here that the real dependency problem is the
> xfs_bmbt_rec_host definition being require by xfs_inode_fork.h.
> That's an in-core definition, and if we move that to another header
> file, we simply create a different dependency instead of removing
> the dependency altogether....

Exactly those. It's been a while since that comment, so for now my
suggested approach would be to merge your series and try to clean things
up later.