Re: [PATCH 04/16] xfs: decouple log and transaction headers

Christoph Hellwig
2013-10-03T14:56:54Z

> @@ -33,16 +33,6 @@ struct xfs_log_vec {
> #define XFS_LOG_VEC_ORDERED (-1)
>
> /*
> - * Structure used to pass callback function and the function's argument
> - * to the log manager.
> - */
> -typedef struct xfs_log_callback {
> - struct xfs_log_callback *cb_next;
> - void (*cb_func)(void *, int);
> - void *cb_arg;
> -} xfs_log_callback_t;
> -
> -/*

Looking at the code I don't think this one needs to be moved as the
t_logcb field in struct xfs_trans is dead already. Just remove it in
a separate patch and this declaration can stay where it is.

Otherwise this patch looks good to me.