From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH 02/12] xfsprogs: reserve v5 superblock read-only compat. feature bit for finobt
Date: Thu, 10 Oct 2013 11:51:02 -0400 [thread overview]
Message-ID: <1381420272-13249-3-git-send-email-bfoster@redhat.com> (raw)
In-Reply-To: <1381420272-13249-1-git-send-email-bfoster@redhat.com>
Reserve a v5 read-only compatibility feature bit for the finobt and
create the xfs_sb_version_hasfinobt() helper to determine whether
an fs has the feature enabled.
The finobt does not change existing on-disk structures, but must
remain consistent with the ialloc btree. Modifications from older
kernels would violate that constrant. Therefore, we restrict older
kernels to read-only mounts of finobt-enabled filesystems.
Note that this does not yet enable the ability to rw mount a finobt
fs (by setting the feature bit in the XFS_SB_FEAT_RO_COMPAT_ALL
mask).
Signed-off-by: Brian Foster <bfoster@redhat.com>
---
include/xfs_sb.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/xfs_sb.h b/include/xfs_sb.h
index c8d8898..83e037b 100644
--- a/include/xfs_sb.h
+++ b/include/xfs_sb.h
@@ -583,6 +583,7 @@ xfs_sb_has_compat_feature(
return (sbp->sb_features_compat & feature) != 0;
}
+#define XFS_SB_FEAT_RO_COMPAT_FINOBT (1 << 0) /* free inode btree */
#define XFS_SB_FEAT_RO_COMPAT_ALL 0
#define XFS_SB_FEAT_RO_COMPAT_UNKNOWN ~XFS_SB_FEAT_RO_COMPAT_ALL
static inline bool
@@ -635,6 +636,12 @@ static inline int xfs_sb_version_hasftype(struct xfs_sb *sbp)
xfs_sb_has_incompat_feature(sbp, XFS_SB_FEAT_INCOMPAT_FTYPE);
}
+static inline int xfs_sb_version_hasfinobt(xfs_sb_t *sbp)
+{
+ return (XFS_SB_VERSION_NUM(sbp) == XFS_SB_VERSION_5) &&
+ (sbp->sb_features_ro_compat & XFS_SB_FEAT_RO_COMPAT_FINOBT);
+}
+
/*
* end of superblock version macros
*/
--
1.8.1.4
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-10-10 15:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-10 15:51 [PATCH 00/12] xfsprogs: introduce the free inode btree Brian Foster
2013-10-10 15:51 ` [PATCH 01/12] xfsprogs: refactor xfs_ialloc_btree.c to support multiple inobt numbers Brian Foster
2013-10-10 15:51 ` Brian Foster [this message]
2013-10-10 15:51 ` [PATCH 03/12] xfsprogs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2013-10-10 15:51 ` [PATCH 04/12] xfsprogs: update inode allocation/free transaction reservations for finobt Brian Foster
2013-10-10 15:51 ` [PATCH 05/12] xfsprogs: insert newly allocated inode chunks into the finobt Brian Foster
2013-10-10 15:51 ` [PATCH 06/12] xfsprogs: use and update the finobt on inode allocation Brian Foster
2013-10-10 15:51 ` [PATCH 07/12] xfsprogs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2013-10-10 15:51 ` [PATCH 08/12] xfsprogs: update the finobt on inode free Brian Foster
2013-10-10 15:51 ` [PATCH 09/12] xfsprogs: enable the finobt feature on v5 superblocks Brian Foster
2013-10-10 15:51 ` [PATCH 10/12] xfsprogs/mkfs: finobt mkfs support Brian Foster
2013-10-10 15:51 ` [PATCH 11/12] xfsprogs/db: finobt support Brian Foster
2013-10-10 15:51 ` [PATCH 12/12] xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1381420272-13249-3-git-send-email-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox