[PATCH] xfstests: use minimum log size in xfs/016

[PATCH] xfstests: use minimum log size in xfs/016

[Brian Foster]

Test xfs/016 fails to run due to invalid mkfs options. The log size
is reported as too small according to the minimum log size
calculation:

log size 512 blocks too small, minimum size is 853 blocks

Update log_size to the currently specified minimum.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 tests/xfs/016 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/xfs/016 b/tests/xfs/016
index 2fc6af2..e52f80c 100755
--- a/tests/xfs/016
+++ b/tests/xfs/016
@@ -181,7 +181,7 @@ _supported_os Linux
 rm -f $seqres.full
 
 # mkfs sizes
-log_size=2097152
+log_size=3493888
 log_size_bb=`expr $log_size / 512`
 
 _require_scratch
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: use minimum log size in xfs/016

[Dave Chinner]

On Fri, Oct 18, 2013 at 01:16:14PM -0400, Brian Foster wrote:
> Test xfs/016 fails to run due to invalid mkfs options. The log size
> is reported as too small according to the minimum log size
> calculation:
> 
> log size 512 blocks too small, minimum size is 853 blocks
> 
> Update log_size to the currently specified minimum.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
> ---
>  tests/xfs/016 | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/016 b/tests/xfs/016
> index 2fc6af2..e52f80c 100755
> --- a/tests/xfs/016
> +++ b/tests/xfs/016
> @@ -181,7 +181,7 @@ _supported_os Linux
>  rm -f $seqres.full
>  
>  # mkfs sizes
> -log_size=2097152
> +log_size=3493888
>  log_size_bb=`expr $log_size / 512`

That shoul dbe fine. I've been ignoring xfs/016 because the
configurations I test throw this:

xfs/016 21s ... [not run] Cannot mkfs for this test using MKFS_OPTIONS specified

And so I haven't noticed if it was failing or not.

Reviewed-by: Dave Chinner <dchinner@redhat.com>

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH] xfstests: use minimum log size in xfs/016

[Rich Johnston]

This has been committed.

Thanks
--Rich

commit bb4074a31abd36426ea6d2ba63764a21b0226635
Author: Brian Foster <bfoster@redhat.com>
Date:   Fri Oct 18 17:16:14 2013 +0000

     xfstests: use minimum log size in xfs/016

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs