Re: [PATCH 19/37] libxfs: refactor libxfs_buf_read_map for xfs_db

Christoph Hellwig
2013-11-07T20:51:09Z

On Wed, Nov 06, 2013 at 12:07:05PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> xfs_db requires low level read/write buffer primitives that are the
> equivalent of libxfs_readbufr/writebufr. The implementation of
> libxfs_writebufr already handles discontiguous buffers, but there is
> no equivalent libxfs_readbufr_map support in the code.
>
> Refactor libxfs_readbuf_map into two parts - one that does the
> buffer cache lookup, and the other that does the read IO. This
> provides the implementation of libxfs_readbufr_map that is required
> for xfs_db.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>