Re: [PATCH 36/37] repair: Increase default repair parallelism on large filesystems

Dave Chinner
2013-11-06T19:13:54Z

On Wed, Nov 06, 2013 at 02:41:11AM -0800, Christoph Hellwig wrote:
> On Wed, Nov 06, 2013 at 12:07:22PM +1100, Dave Chinner wrote:
> > + if (!ag_stride && glob_agcount >= 16 && do_prefetch)
> > + ag_stride = 15;
>
> Shouldn't we have a define for the agcount shared by mkfs and repair, and
> derive the stride from it?
>
> Otherwise looks fine.

Yes, we could.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com