From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay1.corp.sgi.com [137.38.102.111]) by oss.sgi.com (Postfix) with ESMTP id CD9D47F61 for ; Mon, 11 Nov 2013 22:18:04 -0600 (CST) Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by relay1.corp.sgi.com (Postfix) with ESMTP id BAE428F804B for ; Mon, 11 Nov 2013 20:18:04 -0800 (PST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id YZoAce6eFYnRVaFD for ; Mon, 11 Nov 2013 20:18:03 -0800 (PST) Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAC4I2mE024509 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 11 Nov 2013 23:18:02 -0500 From: Eryu Guan Subject: [PATCH RESEND] xfstests: _filter_mkfs should consume input from stdin first to avoid EPIPE Date: Tue, 12 Nov 2013 12:17:54 +0800 Message-Id: <1384229874-30656-1-git-send-email-eguan@redhat.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com Cc: Eryu Guan _filter_mkfs is a filter so that it should read from stdin first before printing anything out. Otherwise the command prior to the pipeline may get EPIPE. I saw this when testing extN with generic/204, _scratch_mkfs_sized was unable to create fs because of EPIPE, then _scratch_mount failed. generic/204 12s ... [failed, exit status 1] - output mismatch (see /root/xfstests/results//generic/204.out.bad) --- tests/generic/204.out 2013-11-01 16:47:56.728591856 +0800 +++ /root/xfstests/results//generic/204.out.bad 2013-11-01 22:52:53.207828779 +0800 @@ -1,2 +1,7 @@ QA output created by 204 -*** done +mount: wrong fs type, bad option, bad superblock on /dev/sda6, + missing codepage or helper program, or other error + In some cases useful info is found in syslog - try + dmesg | tail or so + Signed-off-by: Eryu Guan --- common/filter | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/common/filter b/common/filter index e37ce69..faf33e3 100644 --- a/common/filter +++ b/common/filter @@ -134,16 +134,19 @@ _filter_date() # Non XFS filesystems always return a 4k block size and a 256 byte inode. _filter_mkfs() { + local tmp=/tmp/mkfs_filter + cat - >$tmp + case $FSTYP in xfs) ;; *) perl -e 'print STDERR "dbsize=4096\nisize=256\n"' + rm -f $tmp return ;; esac - set - - perl -ne ' + cat $tmp | perl -ne ' if (/^meta-data=([\w,|\/.-]+)\s+isize=(\d+)\s+agcount=(\d+), agsize=(\d+) blks/) { print STDERR "ddev=$1\nisize=$2\nagcount=$3\nagsize=$4\n"; print STDOUT "meta-data=DDEV isize=XXX agcount=N, agsize=XXX blks\n"; @@ -175,6 +178,7 @@ _filter_mkfs() print STDERR "rtdev=$1\nrtextsz=$2\nrtblocks=$3\nrtextents=$4\n"; print STDOUT "realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX\n"; }' + rm -f $tmp } -- 1.8.3.1 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs