public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH v2 20/20] xfsprogs/db: add finobt support to metadump
Date: Wed, 13 Nov 2013 10:56:22 -0500	[thread overview]
Message-ID: <1384358182-37967-21-git-send-email-bfoster@redhat.com> (raw)
In-Reply-To: <1384358182-37967-1-git-send-email-bfoster@redhat.com>

Include the free inode btree in metadump images. If the source fs
is finobt-enabled, run an additional scan_btree() of the finobt.
Since the private 'agi' scanfunc_ino() parameter is unused, change
the private parameter to a flag that indicates whether the current
scan is for the inobt or finobt. If the latter, we skip copying the
actual inode chunks as this work is already performed by the inobt
scan.

Signed-off-by: Brian Foster <bfoster@redhat.com>
---
 db/metadump.c | 25 ++++++++++++++++++++++++-
 1 file changed, 24 insertions(+), 1 deletion(-)

diff --git a/db/metadump.c b/db/metadump.c
index 117dc42..bb52caf 100644
--- a/db/metadump.c
+++ b/db/metadump.c
@@ -1776,6 +1776,7 @@ scanfunc_ino(
 	xfs_inobt_ptr_t		*pp;
 	int			i;
 	int			numrecs;
+	int			finobt = *(int *) arg;
 
 	numrecs = be16_to_cpu(block->bb_numrecs);
 
@@ -1787,6 +1788,14 @@ scanfunc_ino(
 					typtab[btype].name, agno, agbno);
 			numrecs = mp->m_inobt_mxr[0];
 		}
+
+		/*
+		 * Only copy the btree blocks for the finobt. The inobt scan
+		 * copies the inode chunks.
+		 */
+		if (finobt)
+			return 1;
+
 		rp = XFS_INOBT_REC_ADDR(mp, block, 1);
 		for (i = 0; i < numrecs; i++, rp++) {
 			if (!copy_inode_chunk(agno, rp))
@@ -1826,6 +1835,7 @@ copy_inodes(
 {
 	xfs_agblock_t		root;
 	int			levels;
+	int			finobt = 0;
 
 	root = be32_to_cpu(agi->agi_root);
 	levels = be32_to_cpu(agi->agi_level);
@@ -1844,7 +1854,20 @@ copy_inodes(
 		return 1;
 	}
 
-	return scan_btree(agno, root, levels, TYP_INOBT, agi, scanfunc_ino);
+	if (!scan_btree(agno, root, levels, TYP_INOBT, &finobt, scanfunc_ino))
+		return 0;
+
+	if (xfs_sb_version_hasfinobt(&mp->m_sb)) {
+		root = be32_to_cpu(agi->agi_free_root);
+		levels = be32_to_cpu(agi->agi_free_level);
+
+		finobt = 1;
+		if (!scan_btree(agno, root, levels, TYP_INOBT, &finobt,
+				scanfunc_ino))
+			return 0;
+	}
+
+	return 1;
 }
 
 static int
-- 
1.8.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      parent reply	other threads:[~2013-11-13 15:56 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-13 15:56 [PATCH v2 00/20] xfsprogs: introduce the free inode btree Brian Foster
2013-11-13 15:56 ` [PATCH v2 01/20] xfs: refactor xfs_ialloc_btree.c to support multiple inobt numbers Brian Foster
2013-11-13 15:56 ` [PATCH v2 02/20] xfs: reserve v5 superblock read-only compat. feature bit for finobt Brian Foster
2013-11-13 15:56 ` [PATCH v2 03/20] xfs: support the XFS_BTNUM_FINOBT free inode btree type Brian Foster
2013-11-13 15:56 ` [PATCH v2 04/20] xfs: update inode allocation/free transaction reservations for finobt Brian Foster
2013-11-13 15:56 ` [PATCH v2 05/20] xfs: insert newly allocated inode chunks into the finobt Brian Foster
2013-11-13 15:56 ` [PATCH v2 06/20] xfs: use and update the finobt on inode allocation Brian Foster
2013-11-13 15:56 ` [PATCH v2 07/20] xfs: refactor xfs_difree() inobt bits into xfs_difree_inobt() helper Brian Foster
2013-11-13 15:56 ` [PATCH v2 08/20] xfs: update the finobt on inode free Brian Foster
2013-11-13 15:56 ` [PATCH v2 09/20] xfs: report finobt status in fs geometry Brian Foster
2013-11-13 15:56 ` [PATCH v2 10/20] xfs: enable the finobt feature on v5 superblocks Brian Foster
2013-11-13 15:56 ` [PATCH v2 11/20] xfsprogs/mkfs: finobt mkfs support Brian Foster
2013-11-13 15:56 ` [PATCH v2 12/20] xfsprogs/db: finobt support Brian Foster
2013-11-13 15:56 ` [PATCH v2 13/20] xfsprogs/repair: account for finobt in ag 0 geometry pre-calculation Brian Foster
2013-11-13 15:56 ` [PATCH v2 14/20] xfsprogs/repair: phase 2 finobt scan Brian Foster
2013-11-13 15:56 ` [PATCH v2 15/20] xfsprogs/repair: pass btree block magic as param to build_ino_tree() Brian Foster
2013-11-13 15:56 ` [PATCH v2 16/20] xfsprogs/repair: pull the build_agi() call up out of the inode tree build Brian Foster
2013-11-13 15:56 ` [PATCH v2 17/20] xfsprogs/repair: helpers for finding in-core inode records w/ free inodes Brian Foster
2013-11-13 15:56 ` [PATCH v2 18/20] xfsprogs/repair: reconstruct the finobt in phase 5 Brian Foster
2013-11-13 15:56 ` [PATCH v2 19/20] xfsprogs/growfs: report finobt status in fs geometry (xfs_info) Brian Foster
2013-11-13 15:56 ` Brian Foster [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384358182-37967-21-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox