From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay.sgi.com (relay3.corp.sgi.com [198.149.34.15]) by oss.sgi.com (Postfix) with ESMTP id 3BAD07F52 for ; Wed, 22 Jan 2014 00:46:57 -0600 (CST) Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by relay3.corp.sgi.com (Postfix) with ESMTP id C7A2AAC002 for ; Tue, 21 Jan 2014 22:46:53 -0800 (PST) Received: from ipmail04.adl6.internode.on.net (ipmail04.adl6.internode.on.net [150.101.137.141]) by cuda.sgi.com with ESMTP id qurA8hAhA0ohuFKi for ; Tue, 21 Jan 2014 22:46:49 -0800 (PST) Received: from disappointment.disaster.area ([192.168.1.110] helo=disappointment) by dastard with esmtp (Exim 4.76) (envelope-from ) id 1W5raH-0001UT-EC for xfs@oss.sgi.com; Wed, 22 Jan 2014 17:46:45 +1100 Received: from dave by disappointment with local (Exim 4.80) (envelope-from ) id 1W5raH-0002Gt-D4 for xfs@oss.sgi.com; Wed, 22 Jan 2014 17:46:45 +1100 From: Dave Chinner Subject: [PATCH] xfs/291: fix spurious ENOSPC errors Date: Wed, 22 Jan 2014 17:46:45 +1100 Message-Id: <1390373205-8698-1-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: xfs-bounces@oss.sgi.com Sender: xfs-bounces@oss.sgi.com To: xfs@oss.sgi.com From: Dave Chinner xfs/291 tries to fill the filesystem almost full, so if the log size changes with mkfs defaults then it's free space calculations are not longer valid and so it throws lots of ENOSPC errors during a run. This is not fatal for this test, but it does increase the runtime of it and fill the 291.full file with unnecessary errors. The number of frag files it creates is also too many for a 512 byte inode filesystem (by about 900) so reduce the number of inodes initially created so the test works ofr 512 byte inodes. With 512 byte inodes, the free space histogram looks like this after the frag phase: from to extents blocks pct 1 1 10730 10730 100.00 And for 256 byte inodes: from to extents blocks pct 1 1 12388 12388 100.00 So these changes do not affect the intended operation of the test. Signed-off-by: Dave Chinner --- tests/xfs/291 | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/xfs/291 b/tests/xfs/291 index d5a9b08..0f3f051 100755 --- a/tests/xfs/291 +++ b/tests/xfs/291 @@ -46,7 +46,7 @@ _supported_os IRIX Linux # real QA test starts here rm -f $seqres.full _require_scratch -_scratch_mkfs_xfs -n size=16k -d size=128m >> $seqres.full 2>&1 +_scratch_mkfs_xfs -n size=16k -l size=5m -d size=128m >> $seqres.full 2>&1 _scratch_mount # First we cause very badly fragmented freespace, then @@ -54,13 +54,16 @@ _scratch_mount # should come out very fragmented as a result # Step 1: Cause badly fragmented free space +# +# XXX: this needs to be factored to match what generic/204 does to support +# different inode sizes without ENOSPC mkdir $SCRATCH_MNT/fragdir -for I in `seq 0 27200`; do +for I in `seq 0 26200`; do (echo data > $SCRATCH_MNT/fragdir/f$I) >> $seqres.full 2>&1 done sync -for I in `seq 0 2 27200`; do +for I in `seq 0 2 26200`; do rm -f $SCRATCH_MNT/fragdir/f$I >> $seqres.full 2>&1 done sync -- 1.8.4.rc3 _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs