public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs/296: fix golden output
@ 2014-02-05  1:53 Dave Chinner
  2014-02-05  3:14 ` Eric Sandeen
  0 siblings, 1 reply; 2+ messages in thread
From: Dave Chinner @ 2014-02-05  1:53 UTC (permalink / raw)
  To: xfs

From: Dave Chinner <dchinner@redhat.com>

This test never passed, so the golden output was never properly
verified as correct. Now that the bug is fixed, fix the golden
output to match the actual test output.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
 tests/xfs/296.out | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/xfs/296.out b/tests/xfs/296.out
index 1fb1b69..c279465 100644
--- a/tests/xfs/296.out
+++ b/tests/xfs/296.out
@@ -50,6 +50,7 @@ Checking for xattr on restored file
 user.name
 
 Checking for capability on restored file
-RESTORE_DIR/DUMP_SUBDIR/testfile cap_setgid,cap_setuid+ep
+RESTORE_DIR/DUMP_SUBDIR/testfile = cap_setgid,cap_setuid+ep
 # file: RESTORE_DIR/DUMP_SUBDIR/testfile
 security.capability
+
-- 
1.8.4.rc3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs/296: fix golden output
  2014-02-05  1:53 [PATCH] xfs/296: fix golden output Dave Chinner
@ 2014-02-05  3:14 ` Eric Sandeen
  0 siblings, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2014-02-05  3:14 UTC (permalink / raw)
  To: Dave Chinner, xfs

On 2/4/14, 7:53 PM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> This test never passed, so the golden output was never properly
> verified as correct. Now that the bug is fixed, fix the golden
> output to match the actual test output.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
> ---
>  tests/xfs/296.out | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/xfs/296.out b/tests/xfs/296.out
> index 1fb1b69..c279465 100644
> --- a/tests/xfs/296.out
> +++ b/tests/xfs/296.out
> @@ -50,6 +50,7 @@ Checking for xattr on restored file
>  user.name
>  
>  Checking for capability on restored file
> -RESTORE_DIR/DUMP_SUBDIR/testfile cap_setgid,cap_setuid+ep
> +RESTORE_DIR/DUMP_SUBDIR/testfile = cap_setgid,cap_setuid+ep
>  # file: RESTORE_DIR/DUMP_SUBDIR/testfile
>  security.capability
> +
> 

Hm, thanks.  I guess I just made it up the first time.  ;)

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-02-05  3:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-05  1:53 [PATCH] xfs/296: fix golden output Dave Chinner
2014-02-05  3:14 ` Eric Sandeen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox