From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 2/6] xfs/189: noattr2 invalid for CRC enabled filesystems
Date: Mon, 24 Feb 2014 14:06:11 +1100 [thread overview]
Message-ID: <1393211175-30016-3-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1393211175-30016-1-git-send-email-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
Version 5 filesystems always have attr2 format enabled, and it
cannot be turned off via the noattr2 mount option. As such, attempts
to mount with noattr2 will be rejected and this causes cascading
failures within the test.
Hence detect if we've created a CRC enabled filesystem, and if this
is the case _notrun the test.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
common/attr | 10 ++++++++++
tests/xfs/189 | 2 ++
2 files changed, 12 insertions(+)
diff --git a/common/attr b/common/attr
index 1f3e57f..83bf9d1 100644
--- a/common/attr
+++ b/common/attr
@@ -196,6 +196,16 @@ _require_attr_v1()
|| _notrun "attr v1 not supported on $SCRATCH_DEV"
}
+# check if we support the noattr2 mount option
+_require_noattr2()
+{
+ _scratch_mkfs_xfs > /dev/null 2>&1 \
+ || _fail "_scratch_mkfs_xfs failed on $SCRATCH_DEV"
+ _mount -o noattr2 $SCRATCH_DEV > /dev/null 2>&1 \
+ || _notrun "noattr2 mount option not supported on $SCRATCH_DEV"
+ _scratch_unmount
+}
+
# getfattr -R returns info in readdir order which varies from fs to fs.
# This sorts the output by filename
_sort_getfattr_output()
diff --git a/tests/xfs/189 b/tests/xfs/189
index 27bfb63..a56bbde 100755
--- a/tests/xfs/189
+++ b/tests/xfs/189
@@ -230,6 +230,7 @@ _putback_scratch_fstab()
# get standard environment, filters and checks
. ./common/rc
. ./common/filter
+. ./common/attr
# real QA test starts here
_supported_fs xfs
@@ -237,6 +238,7 @@ _supported_os Linux
_need_to_be_root
_require_scratch
+_require_noattr2
unset SCRATCH_RTDEV
unset SCRATCH_LOGDEV
--
1.8.4.rc3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-02-24 3:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 3:06 [PATCH 0/6] xfstests: fixes for CRCs and small devices Dave Chinner
2014-02-24 3:06 ` [PATCH 1/6] xfs/033: add golden output for CRC enabled filesystems Dave Chinner
2014-02-25 22:05 ` Christoph Hellwig
2014-02-24 3:06 ` Dave Chinner [this message]
2014-02-25 22:05 ` [PATCH 2/6] xfs/189: noattr2 invalid " Christoph Hellwig
2014-02-24 3:06 ` [PATCH 3/6] generic/003: ensure time changes between stat calls Dave Chinner
2014-02-25 22:06 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 4/6] shared/051: CRC enabled filesystems handle more than 25 ACLs Dave Chinner
2014-02-25 22:09 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 5/6] xfs/217: prevent enospc failures on small test devices Dave Chinner
2014-02-25 22:09 ` Christoph Hellwig
2014-02-24 3:06 ` [PATCH 6/6] xfs/167: need at least 10GB of scratch space to run Dave Chinner
2014-02-25 22:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393211175-30016-3-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox