Re: [PATCH 06/10] repair: use a listhead for the dotdot list

Dave Chinner
2014-02-27T02:06:47Z

On Tue, Feb 25, 2014 at 12:03:32PM -0800, Christoph Hellwig wrote:
> On Mon, Feb 24, 2014 at 05:29:25PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Cleanup suggested by Christoph Hellwig - removes another open coded
> > list implementation.
>
> Looks good. Question for both the old and new code: any good reason to
> do the dotdot updates LIFO? If yes it might be worth adding a comment
> about that fact.

No, it didn't even occur to me that it might matter. I'll change it
back to FIFO.

> Reviewed-by: Christoph Hellwig <hch@lst.de>

Thanks,

Dave.
--
Dave Chinner
david@fromorbit.com