From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/3] metadump: fixes for obfuscated dumps
Date: Fri, 28 Feb 2014 17:25:20 +1100 [thread overview]
Message-ID: <1393568723-982-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
The single patch to fix verifier failures in metadata dump has
grown. I identified a problem with processing of multiple objects in
a single buffer which prevented crcs from being calculated correctly
on obfuscated buffers. The first patch fixes that.
The second patch is the 3rd version ofteh original patch. If fixes
the problems that Eric pointed out, and it does the correct thing
w.r.t to contiguous blocks of single objects as well as inodes with
local format data.
The third patch is a fix for a problem that I came across in
testing. fsstress left a symlink that consumed the entire inode
literal area and so exposed a bug in the path name obfuscation where
it failed to correctly recognise the end of the symlink. We don't
store symlinks in null terminated form, so the use of strlen to
calculate the length of the last componenet was a timebomb waiting
to go off...
Cheers,
Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2014-02-28 6:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 6:25 Dave Chinner [this message]
2014-02-28 6:25 ` [PATCH 1/3] metadump: contiguous metadata object need to be split Dave Chinner
2014-02-28 17:52 ` Eric Sandeen
2014-02-28 6:25 ` [PATCH 2/3] metadump: Only verify obfuscated metadata being dumped Dave Chinner
2014-02-28 17:58 ` Eric Sandeen
2014-02-28 6:25 ` [PATCH 3/3] metadump: pathname obfuscation overruns symlink buffer Dave Chinner
2014-02-28 17:44 ` Eric Sandeen
2014-02-28 23:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1393568723-982-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox