linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH v2 0/2] xfs: tmpfile fixes for inode security/acl
Date: Wed,  9 Apr 2014 15:21:49 -0400	[thread overview]
Message-ID: <1397071311-28371-1-git-send-email-bfoster@redhat.com> (raw)

Hi all,

Here's a v2 of the tmpfile and selinux deadlock patch. Since we also
probably want to create the default acl, I created a generic helper out
of xfs_vn_mknod().

Once I got that far, I noticed xfs_create_tmpfile() looked quite similar
to xfs_create(). Patch 2 folds the former into the latter and eliminates
the duplicate code. Patch 2 is optional with regard to addressing the
selinux issue. Lightly tested... thoughts, reviews, flames appreciated.

Brian

v2:
- Added a generic create helper to inherit the security/acl init. code
  in the tmpfile path.
- Added patch 2 to fold xfs_create_tmpfile() into xfs_create().

Brian Foster (2):
  xfs: fix tmpfile/selinux deadlock and initialize security/acl
  xfs: fold xfs_create_tmpfile() into xfs_create()

 fs/xfs/xfs_inode.c | 184 ++++++++++++++---------------------------------------
 fs/xfs/xfs_inode.h |   2 +-
 fs/xfs/xfs_iops.c  |  43 +++++++++----
 fs/xfs/xfs_trace.h |   7 +-
 4 files changed, 81 insertions(+), 155 deletions(-)

-- 
1.8.3.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2014-04-09 19:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-09 19:21 Brian Foster [this message]
2014-04-09 19:21 ` [PATCH v2 1/2] xfs: fix tmpfile/selinux deadlock and initialize security/acl Brian Foster
2014-04-10 10:24   ` Christoph Hellwig
2014-04-10 12:19     ` Brian Foster
2014-04-10 12:29       ` Christoph Hellwig
2014-04-15 17:52         ` Christoph Hellwig
2014-04-15 19:31           ` Andreas Gruenbacher
2014-04-16 11:14             ` Christoph Hellwig
2014-04-16 17:29               ` Andreas Gruenbacher
2014-04-18 16:39                 ` Christoph Hellwig
2014-04-30 12:02   ` Christoph Hellwig
2014-04-09 19:21 ` [PATCH v2 2/2] xfs: fold xfs_create_tmpfile() into xfs_create() Brian Foster
2014-04-10 10:29   ` Christoph Hellwig
2014-04-10 12:19     ` Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1397071311-28371-1-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).