From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 8/9] repair: handle remote symlink CRC errors
Date: Tue, 29 Apr 2014 07:04:58 +1000 [thread overview]
Message-ID: <1398719099-19194-9-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1398719099-19194-1-git-send-email-david@fromorbit.com>
From: Dave Chinner <dchinner@redhat.com>
We can't really repair broken symlink buffer contents, but we can at
least warn about it and correct the CRC error so the symlink is
again readable.
Signed-off-by: Dave Chinner <dchinner@redhat.com>
---
repair/dinode.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/repair/dinode.c b/repair/dinode.c
index b086bec..8891e84 100644
--- a/repair/dinode.c
+++ b/repair/dinode.c
@@ -1254,6 +1254,7 @@ process_symlink_remote(
while (pathlen > 0) {
int blk_cnt = 1;
int byte_cnt;
+ int badcrc = 0;
fsbno = blkmap_get(blkmap, i);
if (fsbno == NULLDFSBNO) {
@@ -1284,6 +1285,12 @@ _("cannot read inode %" PRIu64 ", file block %d, disk block %" PRIu64 "\n"),
lino, i, fsbno);
return 1;
}
+ if (bp->b_error == EFSBADCRC) {
+ do_warn(
+_("Bad symlink buffer CRC, block %" PRIu64 ", inode %" PRIu64 ".\n"
+ "Correcting CRC, but symlink may be bad.\n"), fsbno, lino);
+ badcrc = 1;
+ }
byte_cnt = XFS_SYMLINK_BUF_SPACE(mp, byte_cnt);
byte_cnt = MIN(pathlen, byte_cnt);
@@ -1307,7 +1314,10 @@ _("bad symlink header ino %" PRIu64 ", file block %d, disk block %" PRIu64 "\n")
offset += byte_cnt;
i++;
- libxfs_putbuf(bp);
+ if (badcrc && !no_modify)
+ libxfs_writebuf(bp, 0);
+ else
+ libxfs_putbuf(bp);
}
return 0;
}
--
1.9.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-28 21:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-28 21:04 [PATCH 0/9 v3] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-28 21:04 ` [PATCH 1/9] db: don't claim unchecked CRCs are correct Dave Chinner
2014-04-28 21:04 ` [PATCH 2/9] db: verify buffer on type change Dave Chinner
2014-04-28 21:04 ` [PATCH 3/9] repair: ensure prefetched buffers have CRCs validated Dave Chinner
2014-04-29 14:05 ` Brian Foster
2014-04-29 18:15 ` Christoph Hellwig
2014-04-28 21:04 ` [PATCH 4/9] repair: detect and correct CRC errors in directory blocks Dave Chinner
2014-04-28 21:04 ` [PATCH 5/9] repair: detect CRC errors in AG headers Dave Chinner
2014-04-29 14:06 ` Brian Foster
2014-05-01 23:27 ` Dave Chinner
2014-04-29 18:16 ` Christoph Hellwig
2014-04-28 21:04 ` [PATCH 6/9] repair: report AG btree verifier errors Dave Chinner
2014-04-28 21:04 ` [PATCH 7/9] repair: remove more dirv1 leftovers Dave Chinner
2014-04-28 21:04 ` Dave Chinner [this message]
2014-04-29 14:06 ` [PATCH 8/9] repair: handle remote symlink CRC errors Brian Foster
2014-04-29 18:17 ` Christoph Hellwig
2014-04-28 21:04 ` [PATCH 9/9] repair: detect and handle attribute tree " Dave Chinner
2014-04-29 14:06 ` Brian Foster
2014-04-30 3:55 ` Dave Chinner
2014-04-29 18:18 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2014-04-24 5:01 [PATCH 0/9 V2] xfs_db, xfs_repair: improve CRC error detection Dave Chinner
2014-04-24 5:02 ` [PATCH 8/9] repair: handle remote symlink CRC errors Dave Chinner
2014-04-25 6:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1398719099-19194-9-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).