public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/5] xfs: sanitise supberlock feature bit support
Date: Tue,  6 May 2014 13:55:54 +1000	[thread overview]
Message-ID: <1399348559-19889-1-git-send-email-david@fromorbit.com> (raw)

Hi folks,

This patchset is a followup to the original feature bit cleanup
patch I sent here:

http://oss.sgi.com/archives/xfs/2014-03/msg00101.html

It basically removes all the old cruft that we inherited from Irix
(such as tests and conversion to/from v1-3 superblocks) that we've
never supported on Linux.  On Linux, we've ony ever supported V2
directories, and so anything that doesn't know about V2 directories
is simply going to be rejected at mount time. Hence we don't need
all the code to handle versions older than this.

Nor do we care about Irix bootloader feature bit masks (the SASH
feature bits) or about things that were never implemented like
shared readonly superblock support. Hence we can remove a fairly
large chunk of complexity out of the feature bit testing if we
only test for things that we can support.

Further, we should really always use to v2 inodes these days
on v4 superblock filesystems. We've been setting the NLINK feature
bit by default at mkfs time since 2007, so no we make the kernel set
it by default at mount time, too. This means that we always convert
v1 inodes to v2 inodes, and so reduce the number of different code
paths we need to test and support.

Thoughts, comments?

Cheers,

Dave.

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2014-05-06  3:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06  3:55 Dave Chinner [this message]
2014-05-06  3:55 ` [PATCH 1/5] xfs: make superblock version checks reflect reality Dave Chinner
2014-05-06  8:29   ` Christoph Hellwig
2014-05-06  8:39     ` Dave Chinner
2014-05-06  3:55 ` [PATCH 2/5] xfs: keep sb_bad_features2 the same a sb_features2 Dave Chinner
2014-05-06  8:20   ` Christoph Hellwig
2014-05-06  3:55 ` [PATCH 3/5] xfs: turn NLINK feature on by default Dave Chinner
2014-05-06  8:15   ` Christoph Hellwig
2014-05-06  9:06     ` Dave Chinner
2014-05-06  3:55 ` [PATCH 4/5] xfs: don't need dirv2 checks anymore Dave Chinner
2014-05-06  8:16   ` Christoph Hellwig
2014-05-06  8:45     ` Dave Chinner
2014-05-06  3:55 ` [PATCH 5/5] xfs: remove shared supberlock feature checking Dave Chinner
2014-05-06  7:48   ` Jeff Liu
2014-05-06  8:02     ` Dave Chinner
2014-05-06  8:18   ` Christoph Hellwig
2014-05-06  8:28     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1399348559-19889-1-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox