From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/9] xfs: error sign fixes for 3.15-rc6
Date: Tue, 13 May 2014 18:56:04 +1000 [thread overview]
Message-ID: <1399971373-6242-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
I've been working through the mess that is the
error sign impedance mismatch between the core XFS code and the rest
of the kernel. I'm about half way through the codebase, and I've
found a bunch of incorrect error signs throughout the VFS interface
layers.
These were effectively all found by inspection, and is
further evidence that we need to convert all of XFS to negative
errors as quickly as possible. It is clear that we are missing these
on review, and changes made by developers adding functionality to
the VFS and hence just touching the outer layers of XFS are
simply not aware of these issues in the first place.
This patchset is based on v3.15-rc5 because some of the problems that
need to be fixed have merged into mainline via the ext4 tree
(COLLAPSE_RANGE changes). Hence I'll need to update the master
branch of the XFS tree to v3.15-rc5 before I merge these and push
them to Linus. I'm considering them as important fixes as things
like xfs_dir_fsync() and xfs_commit_metadata() returning incorrect
errnos mean data integrity operation failures may not be detected
correctly by applications.....
Comments, thoughts, testing all welcome!
Cheers,
Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2014-05-13 8:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 8:56 Dave Chinner [this message]
2014-05-13 8:56 ` [PATCH 1/9] xfs: xfs_dir_fsync() returns positive errno Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 2/9] xfs: fix incorrect error sign in xfs_file_aio_read Dave Chinner
2014-05-13 12:46 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 3/9] xfs: xfs_commit_metadata returns wrong errno Dave Chinner
2014-05-13 12:48 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 4/9] xfs: correct error sign on COLLAPSE_RANGE errors Dave Chinner
2014-05-13 12:49 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 5/9] xfs: fix wrong errno from xfs_initxattrs Dave Chinner
2014-05-13 12:51 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 6/9] xfs: fix wrong err sign on xfs_set_acl() Dave Chinner
2014-05-13 12:51 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 7/9] xfs: negate mount workqueue init error value Dave Chinner
2014-05-13 12:56 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 8/9] xfs: negate xfs_icsb_init_counters " Dave Chinner
2014-05-13 12:58 ` Jeff Liu
2014-05-13 8:56 ` [PATCH 9/9] xfs: list_lru_init returns a negative error Dave Chinner
2014-05-13 13:05 ` Jeff Liu
2014-05-14 7:28 ` [PATCH 0/9] xfs: error sign fixes for 3.15-rc6 Jeff Liu
2014-05-14 21:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1399971373-6242-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox