Re: [PATCH 02/16] xfs: move directory block translatiosn to xfs_da_btree.h

Dave Chinner
2014-05-27T23:07:04Z

On Tue, May 27, 2014 at 03:46:38AM -0700, Christoph Hellwig wrote:
> On Fri, May 23, 2014 at 10:03:38AM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Because they aren't actually part of the on-disk format, and so
> > shouldn't be in xfs_da_format.h.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
>
> Maybe it's time to rename the functions and types from xfs_dir2_* to
> xfs_da_* as we already do for some? If not this should stay in dir2
> headers.

Fair call - they really are dir2 specific, so probably should be in
xfs_dir2_priv.h, not xfs_da_btree.h.

OK, I can update this patch to do that. I'll need to repost the
series, because I'll have to rework a significant number of the
patches...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com