Re: [PATCH v2 3/6] xfs: add xfs_mount sysfs kobject

Dave Chinner
2014-06-28T00:56:21Z

On Fri, Jun 27, 2014 at 08:06:58AM -0400, Brian Foster wrote:
> Embed a base kobject into xfs_mount. This creates a kobject associated
> with each XFS mount and a subdirectory in sysfs with the name of the
> filesystem. The subdirectory lifecycle matches that of the mount. Also
> add the new xfs_sysfs.[c,h] source files with some XFS sysfs
> infrastructure to facilitate attribute creation.
>
> Note that there are currently no attributes exported as part of the
> xfs_mount kobject. It exists solely to serve as a per-mount container
> for child objects.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>

One minor thing I can clean up directly:

> +static inline int
> +xfs_sysfs_init(
> + struct xfs_kobj *kobj,
> + struct kobj_type *ktype,
> + struct xfs_kobj *p_kobj,
^^^^^^

parent_kobj would be better - that looks too much like hungarian
notation... :)

Other than that,

Reviewed-by: Dave Chinner <dchinner@redhat.com>

--
Dave Chinner
david@fromorbit.com