Re: [PATCH 3/6] repair: handle directory block corruption in phase 6

Christoph Hellwig
2014-07-04T14:24:24Z

> @@ -2179,7 +2179,7 @@ longform_dir2_entry_check(xfs_mount_t *mp,
> freetab = malloc(FREETAB_SIZE(ip->i_d.di_size / mp->m_dirblksize));
> if (!freetab) {
> do_error(
> - _("malloc failed in longform_dir2_entry_check (%" PRId64 " bytes)\n"),
> +_("malloc failed in longform_dir2_entry_check (%" PRId64 " bytes)\n"),

Use __func__ to make this both more readable and future proof (same for
the other error message).

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>