Re: [PATCH 2/6] xfs_db: write command broken on 64 bit values

Christoph Hellwig
2014-07-04T14:08:56Z

On Fri, Jul 04, 2014 at 03:57:11PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> convert_args() has problesm with 64 bit fields because it tries to
> shift them by 64 bits. The result of doing so is undefined by the C
> standard, and so results in the unexpected behaviour of the result
> being being the original value unchanged rather than 0. Hence you
> can't write 64 bit fields because the code thinks that all values
> other than 0 are out of range.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>