From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Cc: iusty@k1024.org
Subject: [PATCH 0/2] xfs: cleanup XFS_IOC_SETXATTR behaviour
Date: Tue, 30 Sep 2014 11:46:03 +1000 [thread overview]
Message-ID: <1412041565-18873-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
A while back Iustin Pop sent a patch to fix a problem with being
unable to set extent size hint values on directories. That patch -
along with new xfstests functionality to always check the scratch
device after a test - has pointed out that we allow certain
directory only inode flags to be set on other types of inodes (e.g.
regular files). It also pointed out that we could set extent size
hints on inodes that don't have extent size hint flags set.
This patchset does not attempt to fix the original problem, not add
any new validation of what is passed from userspace. Instead, it
simply ensures that what we end up with on disk is valid. That is,
directory only flags are only set on directory inodes, and extent
size hints are set if the inode flags are set, otherwise it is
cleared. Hence we don't end up with "invalid" state on disk, and so
xfstests doesn't get upset with directory only flags being set on
non directory inodes.
Further followups will be needed to address the original issue of
changing extent size hints on directories and handling invalid
flag/value combinations from userspace. I have not attempted to
solve that problem here because it could have impact on userspace
application behaviour and that's a different issue to ensuring we
end up with valid inode state on disk.
Thoughts, comments, flames?
Cheers,
Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2014-09-30 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 1:46 Dave Chinner [this message]
2014-09-30 1:46 ` [PATCH 1/2] xfs: project id inheritance is a directory only flag Dave Chinner
2014-10-01 11:58 ` Brian Foster
2014-09-30 1:46 ` [PATCH 2/2] xfs: only set extent size hint when asked Dave Chinner
2014-09-30 5:58 ` Iustin Pop
2014-09-30 22:13 ` Dave Chinner
2014-10-01 11:59 ` Brian Foster
2014-10-01 23:21 ` Dave Chinner
2014-09-30 5:55 ` [PATCH 0/2] xfs: cleanup XFS_IOC_SETXATTR behaviour Iustin Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1412041565-18873-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=iusty@k1024.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox