From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Cc: bvowk@box.com
Subject: [PATCH 0/2] repair: fix AGFL rebuild problem
Date: Wed, 29 Oct 2014 14:09:02 +1100 [thread overview]
Message-ID: <1414552144-12627-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
The following two patches fix a repair rebuild issue that was
reported to me. xfs_repair would appear to succeed, but subsequent
runs would report a freespace mismatch and then on mount trigger
a corruption error on the first allocation from AG 0.
The problem as that the AGFL was not being correctly rebuilt due to
a very particular freespace pattern in AG 0 which required free
blocks in the AGFL to populate an empty AGFL. reapir silently
ignored this error, so it triggered allocation corruption errors
when the same AGFL fixup attempt failed on a mounted filesystem.
The fix is relatively straight forward, as is the fixes to the
tracing code that I had to make before i could track down the issue.
-Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2014-10-29 3:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 3:09 Dave Chinner [this message]
2014-10-29 3:09 ` [PATCH 1/2] repair: fix XR_BLD_FREE_TRACE compilation errors Dave Chinner
2014-10-29 4:03 ` Eric Sandeen
2014-10-29 19:24 ` Brian Foster
2014-10-29 3:09 ` [PATCH 2/2] repair: AGFL rebuild fails if btree split required Dave Chinner
2014-10-29 19:26 ` Brian Foster
2014-10-29 19:59 ` Dave Chinner
2014-10-30 13:42 ` Brian Foster
2014-10-29 18:23 ` [PATCH 0/2] repair: fix AGFL rebuild problem Barkley Vowk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414552144-12627-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=bvowk@box.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox