public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/2] xfsprogs/repair: secondary sb scan cleanups
Date: Tue, 13 Jan 2015 15:08:11 -0500	[thread overview]
Message-ID: <1421179693-17227-1-git-send-email-bfoster@redhat.com> (raw)

Hi all,

Here are a couple patches to clean up the secondary sb scanning in phase
1 of xfs_repair. Patch 1 is a fix for a bug encountered by a user with a
corrupted fs/array that lead to scattered sb corruption:

http://oss.sgi.com/archives/xfs/2015-01/msg00113.html

Patch 2 is a larger cleanup of the affected sb scan function after
reading through the code and not being able to grok the need for some of
the extra complexity therein. I don't think it should affect behavior
much, but thoughts appreciated.

Brian

Brian Foster (2):
  repair: fix unnecessary secondary scan if only last sb is corrupt
  repair: remove unused strided secondary sb scan logic

 repair/globals.h |  2 --
 repair/sb.c      | 67 +++++++++++++++++++-------------------------------------
 2 files changed, 22 insertions(+), 47 deletions(-)

-- 
1.8.3.1

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2015-01-13 20:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-13 20:08 Brian Foster [this message]
2015-01-13 20:08 ` [PATCH 1/2] repair: fix unnecessary secondary scan if only last sb is corrupt Brian Foster
2015-01-15 21:44   ` Eric Sandeen
2015-01-16 12:05     ` Brian Foster
2015-01-13 20:08 ` [PATCH 2/2] repair: remove unused strided secondary sb scan logic Brian Foster
2015-01-15 23:15   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421179693-17227-1-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox