Re: [PATCH 1/3] xfs: Remove useless test

Brian Foster
2015-01-15T13:28:07Z

On Thu, Jan 15, 2015 at 11:18:03AM +0100, Jan Kara wrote:
> Q_XQUOTARM is never passed to xfs_fs_set_xstate() so remove the test.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

> fs/xfs/xfs_quotaops.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_quotaops.c b/fs/xfs/xfs_quotaops.c
> index 7542bbeca6a1..8fcd20dbf89a 100644
> --- a/fs/xfs/xfs_quotaops.c
> +++ b/fs/xfs/xfs_quotaops.c
> @@ -75,7 +75,7 @@ xfs_fs_set_xstate(
>
> if (sb->s_flags & MS_RDONLY)
> return -EROFS;
> - if (op != Q_XQUOTARM && !XFS_IS_QUOTA_RUNNING(mp))
> + if (!XFS_IS_QUOTA_RUNNING(mp))
> return -ENOSYS;
>
> if (uflags & FS_QUOTA_UDQ_ACCT)
> --
> 2.1.2
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs