From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/7 V2] xfs: use generic percpu counters for icsb
Date: Thu, 5 Feb 2015 07:54:02 +1100 [thread overview]
Message-ID: <1423083249-27493-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
This is the second version of the generic per-cpu counter rework
patch series. The first version can be found here:
http://oss.sgi.com/archives/xfs/2015-02/msg00000.html
New in V2:
- drop the moving of the struct xfs_sb to xfs_super.h
- fixed all the little things that Christoph and Brian noted.
- keep the per-cpu counters in the struct xfs_mount and keep the
functions to sync them with the struct xfs_sb values when read
from disk or written to disk.
- integrated Christoph Hellwig's additional cleanup patch. This was
done by:
- intergating xfs_mod_XXX factoring into the relevant percpu
counter conversion patch
- separating out xfs_mod_frextents into it's won patch
- separating out the replacement of
xfs_mod_incore_sb_batched
- doing all the now unused API removal in a separate patch
The series passes xfstests without regressions, and no scalability
issues have been seen in my performance tests on a 16p VM. SGI - you
still need to test this, though. :)
Thoughts, comments?
-Dave.
PS: diffstat of the series is now:
fs/xfs/libxfs/xfs_bmap.c | 40 +--
fs/xfs/libxfs/xfs_format.h | 62 ----
fs/xfs/libxfs/xfs_ialloc.c | 6 +-
fs/xfs/libxfs/xfs_sb.c | 12 +-
fs/xfs/xfs_fsops.c | 20 +-
fs/xfs/xfs_iomap.c | 3 +-
fs/xfs/xfs_linux.h | 9 -
fs/xfs/xfs_log_recover.c | 4 +-
fs/xfs/xfs_mount.c | 919 ++++++-----------------------------------------
fs/xfs/xfs_mount.h | 95 +----
fs/xfs/xfs_super.c | 103 ++++--
fs/xfs/xfs_super.h | 2 +
fs/xfs/xfs_trans.c | 234 +++++++-----
13 files changed, 381 insertions(+), 1128 deletions(-)
So we have a net reduction of roughly 750 lines of code. When
combined with the changes to the superblock logging that has already
been committed, we have reduced the superblock modification code by
close to 1000 lines compared to 3.19...
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2015-02-04 20:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-04 20:54 Dave Chinner [this message]
2015-02-04 20:54 ` [PATCH 1/7] xfs: use generic percpu counters for inode counter Dave Chinner
2015-02-05 14:09 ` Brian Foster
2015-02-23 20:55 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 2/7] xfs: use generic percpu counters for free " Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 20:56 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 3/7] xfs: use generic percpu counters for free block counter Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:18 ` Brian Foster
2015-02-23 20:57 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 4/7] xfs: Remove icsb infrastructure Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 20:59 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 5/7] xfs: introduce xfs_mod_frextents Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-23 21:02 ` Christoph Hellwig
2015-02-04 20:54 ` [PATCH 6/7] xfs: replace xfs_mod_incore_sb_batched Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:19 ` Christoph Hellwig
2015-02-05 14:27 ` Brian Foster
2015-02-04 20:54 ` [PATCH 7/7] xfs: remove xfs_mod_incore_sb API Dave Chinner
2015-02-05 14:10 ` Brian Foster
2015-02-05 14:08 ` [PATCH 0/7 V2] xfs: use generic percpu counters for icsb Brian Foster
2015-02-05 22:18 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423083249-27493-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox