From: Joe Perches <joe@perches.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent
Date: Tue, 03 Mar 2015 12:39:42 -0800 [thread overview]
Message-ID: <1425415182.17273.59.camel@perches.com> (raw)
In-Reply-To: <1425410469-26098-1-git-send-email-fabf@skynet.be>
On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote:
> new_parent is only used in 0/1 context.
[]
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
[]
> @@ -2860,7 +2860,7 @@ xfs_rename(
> {
> xfs_trans_t *tp = NULL;
> xfs_mount_t *mp = src_dp->i_mount;
> - int new_parent; /* moving to a new dir */
> + bool new_parent; /* moving to a new dir */
> int src_is_directory; /* src_name is a directory */
Could convert src_is_directory to bool too.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
parent reply other threads:[~2015-03-03 20:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1425410469-26098-1-git-send-email-fabf@skynet.be>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1425415182.17273.59.camel@perches.com \
--to=joe@perches.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox