* Re: [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent
[not found] <1425410469-26098-1-git-send-email-fabf@skynet.be>
@ 2015-03-03 20:39 ` Joe Perches
0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2015-03-03 20:39 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, xfs
On Tue, 2015-03-03 at 20:21 +0100, Fabian Frederick wrote:
> new_parent is only used in 0/1 context.
[]
> diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c
[]
> @@ -2860,7 +2860,7 @@ xfs_rename(
> {
> xfs_trans_t *tp = NULL;
> xfs_mount_t *mp = src_dp->i_mount;
> - int new_parent; /* moving to a new dir */
> + bool new_parent; /* moving to a new dir */
> int src_is_directory; /* src_name is a directory */
Could convert src_is_directory to bool too.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2015-03-03 20:39 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1425410469-26098-1-git-send-email-fabf@skynet.be>
2015-03-03 20:39 ` [PATCH 1/1 linux-next] xfs: use bool instead of int for new_parent Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox