[PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[Nicholas Krause]

This makes the function,xfs_alloc_lookup_eq static as there are no
calls to this function outside the definition file for this function,
xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 516162b..48de3f0 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
 /*
  * Lookup the record equal to [bno, len] in the btree given by cur.
  */
-STATIC int				/* error */
+static int				/* error */
 xfs_alloc_lookup_eq(
 	struct xfs_btree_cur	*cur,	/* btree cursor */
 	xfs_agblock_t		bno,	/* starting block of extent */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 02/12] xfs:Make the function,xfs_alloc_update static

[Nicholas Krause]

This makes the function xfs_alloc_update now to be
a statically defined function due to no callers
outside of the declarition file,xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 48de3f0..096c6c8 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -101,7 +101,7 @@ xfs_alloc_lookup_le(
  * by [bno, len].
  * This either works (return 0) or gets an EFSCORRUPTED error.
  */
-STATIC int				/* error */
+static int				/* error */
 xfs_alloc_update(
 	struct xfs_btree_cur	*cur,	/* btree cursor */
 	xfs_agblock_t		bno,	/* starting block of extent */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 03/12] xfs:Make the function,xfs_alloc_compute_aligned static

[Nicholas Krause]

This makes the function,xfs_alloc_compute_aligned static
now as there are no callers outside of the function's
declariton file.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 096c6c8..5e575ac 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -139,7 +139,7 @@ xfs_alloc_get_rec(
  * Compute aligned version of the found extent.
  * Takes alignment and min length into account.
  */
-STATIC void
+static void
 xfs_alloc_compute_aligned(
 	xfs_alloc_arg_t	*args,		/* allocation argument structure */
 	xfs_agblock_t	foundbno,	/* starting block in found extent */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 04/12] xfs:Make the function,xfs_alloc_fix_len static

[Nicholas Krause]

This properly makes the function,xfs_alloc_fix_len static
due to no callers outside of the file this function is
declared and defined in.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 5e575ac..71d20a4 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -239,7 +239,7 @@ xfs_alloc_compute_diff(
  * If len is too small it is returned unchanged.
  * If len hits maxlen it is left alone.
  */
-STATIC void
+static void
 xfs_alloc_fix_len(
 	xfs_alloc_arg_t	*args)		/* allocation argument structure */
 {
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 05/12] xfs:Make the function, xfs_alloc_fix_minleft static

[Nicholas Krause]

This makes the function, xfs_alloc_fix_minleft to be static
due to no callers of this function outside the file,xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 71d20a4..fdf2877 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -272,7 +272,7 @@ xfs_alloc_fix_len(
  * Fix up length if there is too little space left in the a.g.
  * Return 1 if ok, 0 if too little, should give up.
  */
-STATIC int
+static int
 xfs_alloc_fix_minleft(
 	xfs_alloc_arg_t	*args)		/* allocation argument structure */
 {
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 06/12] xfs:Make the function,xfs_alloc_fixup_trees static

[Nicholas Krause]

This makes the function,xfs_alloc_fixup_trees static now due to
it having no external callers outside of the file,xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index fdf2877..4492311 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -301,7 +301,7 @@ xfs_alloc_fix_minleft(
  * Flags are passed in indicating whether the cursors are set to the
  * relevant records.
  */
-STATIC int				/* error code */
+static int				/* error code */
 xfs_alloc_fixup_trees(
 	xfs_btree_cur_t	*cnt_cur,	/* cursor for by-size btree */
 	xfs_btree_cur_t	*bno_cur,	/* cursor for by-block btree */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 07/12] xfs:Make the function,xfs_alloc_read_agfl static

[Nicholas Krause]

This makes the function,xfs_alloc_read_agfl static now due to
having no external callers outside the file,xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 4492311..53ed3f3 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -526,7 +526,7 @@ const struct xfs_buf_ops xfs_agfl_buf_ops = {
 /*
  * Read in the allocation group free block array.
  */
-STATIC int				/* error */
+static int				/* error */
 xfs_alloc_read_agfl(
 	xfs_mount_t	*mp,		/* mount point structure */
 	xfs_trans_t	*tp,		/* transaction pointer */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 08/12] xfs:Make the function,xfs_alloc_update_counters static

[Nicholas Krause]

This makes the function,xfs_alloc_update_counters static now
due to no external callers to this function for other files.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 53ed3f3..2f94b53 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -548,7 +548,7 @@ xfs_alloc_read_agfl(
 	return 0;
 }
 
-STATIC int
+static int
 xfs_alloc_update_counters(
 	struct xfs_trans	*tp,
 	struct xfs_perag	*pag,
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 09/12] xfs:Make the function,xfs_alloc_ag_vextent static

[Nicholas Krause]

This makes the function,xfs_alloc_ag_vextent static
now due to its only callers being in the same file
as this function's declaration and definition.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 2f94b53..3c9a58f 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -581,7 +581,7 @@ xfs_alloc_update_counters(
  * and of the form k * prod + mod unless there's nothing that large.
  * Return the starting a.g. block, or NULLAGBLOCK if we can't do it.
  */
-STATIC int			/* error */
+static int			/* error */
 xfs_alloc_ag_vextent(
 	xfs_alloc_arg_t	*args)	/* argument structure for allocation */
 {
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 10/12] xfs:Make the function, xfs_alloc_find_best_extent static

[Nicholas Krause]

This makes the function, xfs_alloc_find_best_extent to be static
now due to having no external calls to this function.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index 3c9a58f..cd09335 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -760,7 +760,7 @@ error0:
  * Search the btree in a given direction via the search cursor and compare
  * the records found against the good extent we've already found.
  */
-STATIC int
+static int
 xfs_alloc_find_best_extent(
 	struct xfs_alloc_arg	*args,	/* allocation argument structure */
 	struct xfs_btree_cur	**gcur,	/* good cursor */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 11/12] xfs:Make the function,xfs_free_ag_extent static

[Nicholas Krause]

This makes the function,xfs_free_ag_extent static now due
to having no external callers from outside the declaration
file,xfs_alloc.c.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index cd09335..cbdd804 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -1542,7 +1542,7 @@ error0:
 /*
  * Free the extent starting at agno/bno for length.
  */
-STATIC int			/* error */
+static int			/* error */
 xfs_free_ag_extent(
 	xfs_trans_t	*tp,	/* transaction pointer */
 	xfs_buf_t	*agbp,	/* buffer for a.g. freelist header */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

[PATCH 12/12] xfs:Make the function,xfs_alloc_fix_freelist static

[Nicholas Krause]

This makes the function,xfs_alloc_fix_freelist static now
due to it having no external callers.

Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
---
 fs/xfs/libxfs/xfs_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
index cbdd804..6628d5e 100644
--- a/fs/xfs/libxfs/xfs_alloc.c
+++ b/fs/xfs/libxfs/xfs_alloc.c
@@ -1842,7 +1842,7 @@ xfs_alloc_longest_free_extent(
  * Decide whether to use this allocation group for this allocation.
  * If so, fix up the btree freelist's size.
  */
-STATIC int			/* error */
+static int			/* error */
 xfs_alloc_fix_freelist(
 	xfs_alloc_arg_t	*args,	/* allocation argument structure */
 	int		flags)	/* XFS_ALLOC_FLAG_... */
-- 
2.1.4

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[Christoph Hellwig]

On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
> This makes the function,xfs_alloc_lookup_eq static as there are no
> calls to this function outside the definition file for this function,
> xfs_alloc.c.

Nic, please stop trolling our lists.

Thank you, and *plonk*

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[nick]

On 2015-05-05 04:18 PM, Christoph Hellwig wrote:
> On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
>> This makes the function,xfs_alloc_lookup_eq static as there are no
>> calls to this function outside the definition file for this function,
>> xfs_alloc.c.
> 
> Nic, please stop trolling our lists.
> 
> Thank you, and *plonk*
> 
I am no trying to troll here, these are built tested and
apply fine for me.
Nick

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[Dave Chinner]

On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
> This makes the function,xfs_alloc_lookup_eq static as there are no
> calls to this function outside the definition file for this function,
> xfs_alloc.c.
> 
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  fs/xfs/libxfs/xfs_alloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> index 516162b..48de3f0 100644
> --- a/fs/xfs/libxfs/xfs_alloc.c
> +++ b/fs/xfs/libxfs/xfs_alloc.c
> @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
>  /*
>   * Lookup the record equal to [bno, len] in the btree given by cur.
>   */
> -STATIC int				/* error */
> +static int				/* error */
>  xfs_alloc_lookup_eq(
>  	struct xfs_btree_cur	*cur,	/* btree cursor */
>  	xfs_agblock_t		bno,	/* starting block of extent */

Please have a look at what STATIC actually means, and then use the
sparse checker to confirm that these functions are already static
for a CONFIG_XFS_DEBUG=n build.

i.e. STATIC is a stack usage minimisation and debugging aid, not
something that is broken and needs fixing.

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

Re: [PATCH 01/12] xfs:Make the function,xfs_alloc_lookup_eq static

[nick]

On 2015-05-05 06:12 PM, Dave Chinner wrote:
> On Tue, May 05, 2015 at 04:16:28PM -0400, Nicholas Krause wrote:
>> This makes the function,xfs_alloc_lookup_eq static as there are no
>> calls to this function outside the definition file for this function,
>> xfs_alloc.c.
>>
>> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
>> ---
>>  fs/xfs/libxfs/xfs_alloc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
>> index 516162b..48de3f0 100644
>> --- a/fs/xfs/libxfs/xfs_alloc.c
>> +++ b/fs/xfs/libxfs/xfs_alloc.c
>> @@ -52,7 +52,7 @@ STATIC int xfs_alloc_ag_vextent_small(xfs_alloc_arg_t *,
>>  /*
>>   * Lookup the record equal to [bno, len] in the btree given by cur.
>>   */
>> -STATIC int				/* error */
>> +static int				/* error */
>>  xfs_alloc_lookup_eq(
>>  	struct xfs_btree_cur	*cur,	/* btree cursor */
>>  	xfs_agblock_t		bno,	/* starting block of extent */
> 
> Please have a look at what STATIC actually means, and then use the
> sparse checker to confirm that these functions are already static
> for a CONFIG_XFS_DEBUG=n build.
> 
> i.e. STATIC is a stack usage minimisation and debugging aid, not
> something that is broken and needs fixing.
> 
> Cheers,
> 
> Dave.
> 
That's Ok I wasn't sure if that was there for those reasons.Next time 
I will be more careful and check out the macros I don't known. :(
Sorry,
Nick 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs