public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/4] xfsprogs/repair: sparse inode chunks cleanups
Date: Mon,  8 Jun 2015 07:29:20 -0400	[thread overview]
Message-ID: <1433762964-11502-1-git-send-email-bfoster@redhat.com> (raw)

Hi all,

This is a small cleanup series for some of the repair code touched by
the sparse inode chunks feature, in response to review comments in the
following thread:

	http://oss.sgi.com/archives/xfs/2015-06/msg00053.html

It primarily creates a few helper functions for hunks of code executed
multiple times or code that is common between the increasingly similar
but separate inobt and finobt record scanning code. For much of the
latter code, the only difference between the separate functions is the
error message output to indicate which tree is affected by a problem.
Therefore, I abstracted out the inobt name and factored out some helpers
that can perform the appropriate checks regardless of the tree type.

This series is purely cleanup and should not alter functionality in any
way. Thoughts?

Brian

Brian Foster (4):
  repair: access helpers for on-disk inobt record freecount
  repair: helper for inode chunk alignment and start/end ino number
    verification
  repair: helper to import on-disk inobt records to in-core trees
  repair: helper to transition inode blocks to inode state

 repair/dino_chunks.c |  91 ++++++-------
 repair/incore.h      |  28 ++++
 repair/phase5.c      |  12 +-
 repair/scan.c        | 377 +++++++++++++++++++++++++--------------------------
 4 files changed, 259 insertions(+), 249 deletions(-)

-- 
1.9.3

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2015-06-08 11:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-08 11:29 Brian Foster [this message]
2015-06-08 11:29 ` [PATCH 1/4] repair: access helpers for on-disk inobt record freecount Brian Foster
2015-06-08 11:29 ` [PATCH 2/4] repair: helper for inode chunk alignment and start/end ino number verification Brian Foster
2015-06-08 11:29 ` [PATCH 3/4] repair: helper to import on-disk inobt records to in-core trees Brian Foster
2015-06-08 11:29 ` [PATCH 4/4] repair: helper to transition inode blocks to inode state Brian Foster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1433762964-11502-1-git-send-email-bfoster@redhat.com \
    --to=bfoster@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox