Re: [PATCH 17/17] mkfs: move spinodes crc check

Brian Foster
2015-06-26T19:32:43Z

On Fri, Jun 19, 2015 at 01:02:06PM +0200, Jan Ťulák wrote:
> Spinodes crc check is now moved to be in the same way as finobt.
>
> Signed-off-by: Jan Ťulák <jtulak@redhat.com>
> ---

Seems fine:

Reviewed-by: Brian Foster <bfoster@redhat.com>

> mkfs/xfs_mkfs.c | 11 ++++++-----
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 2e455db..653fc5b 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -2347,12 +2347,13 @@ _("32 bit Project IDs always enabled on CRC enabled filesytems\n"));
> _("warning: finobt not supported without CRC support, disabled.\n"));
> sb_feat.finobt = 0;
> }
> - }
>
> - if (sb_feat.spinodes && !sb_feat.crcs_enabled) {
> - fprintf(stderr,
> -_("warning: sparse inodes not supported without CRC support, disabled.\n"));
> - sb_feat.spinodes = 0;
> + if (sb_feat.spinodes) {
> + fprintf(stderr,
> + _("warning: sparse inodes not supported without CRC support, disabled.\n"));
> + sb_feat.spinodes = 0;
> + }
> +
> }
>
> if (nsflag || nlflag) {
> --
> 2.1.0
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs