From: Theodore Ts'o <tytso@mit.edu>
To: xfs@oss.sgi.com
Cc: Theodore Ts'o <tytso@mit.edu>, fstests@vger.kernel.org
Subject: [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename()
Date: Sun, 26 Jul 2015 08:20:51 -0400 [thread overview]
Message-ID: <1437913255-7524-3-git-send-email-tytso@mit.edu> (raw)
In-Reply-To: <1437913255-7524-1-git-send-email-tytso@mit.edu>
The function prototype for basename() is in <libgen.h>, per Posix.
Without the the function prototype, the build will throw errors due to
the missing prototype.
On glibc, using libgen.h will force the use of Poxis's basename(),
instead of glibc's basename() with GNU extensions. However, xfsprogs
doesn't depend on any of the GNU extensions, so this is fine.
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---
include/platform_defs.h.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in
index 3e059af..bfab7cc 100644
--- a/include/platform_defs.h.in
+++ b/include/platform_defs.h.in
@@ -35,6 +35,7 @@
#include <sys/types.h>
#include <limits.h>
#include <stdbool.h>
+#include <libgen.h>
#undef HAVE___U32
#ifdef HAVE___U32
--
2.3.0
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-07-26 12:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-26 12:20 [PATCH 0/6] Add cross-compilation support for android Theodore Ts'o
2015-07-26 12:20 ` [PATCH 1/6] xfsprogs: define NBBY if not defined by the system header files Theodore Ts'o
2015-07-30 17:07 ` Christoph Hellwig
2015-07-26 12:20 ` Theodore Ts'o [this message]
2015-07-30 17:11 ` [PATCH 2/6] xfsprogs: pull in libgen.h to get prototype for basename() Christoph Hellwig
2015-07-26 12:20 ` [PATCH 3/6] xfsprogs: define and use BUILD_CC in configure.ac for cross compilation Theodore Ts'o
2015-07-30 17:10 ` Christoph Hellwig
2016-02-01 21:25 ` xfsprogs: Add BUILD_CFLAGS " Gwendal Grignou
2016-02-02 18:08 ` Christoph Hellwig
2016-05-27 16:34 ` Gwendal Grignou
2016-05-31 12:51 ` Christoph Hellwig
2016-05-31 16:19 ` Gwendal Grignou
2015-07-26 12:20 ` [PATCH 4/6] xfsprogs: avoid use of si_tid in struct xlog_split_item Theodore Ts'o
2015-07-30 17:11 ` Christoph Hellwig
2015-07-26 12:20 ` [PATCH 5/6] xfsprogs: use "unsigned short" instead of ushort Theodore Ts'o
2015-07-30 17:09 ` Christoph Hellwig
2015-07-26 12:20 ` [PATCH 6/6] xfsprogs: add missing include of <stat.h> Theodore Ts'o
2015-07-30 17:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437913255-7524-3-git-send-email-tytso@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox