Re: [PATCH v3 04/11] xfsprogs: Add ifdef dirent checks where it was missing

Jan Tulak
2015-08-04T09:21:46Z

----- Original Message -----
> From: "Christoph Hellwig" <hch@infradead.org>
> To: "Jan Tulak" <jtulak@redhat.com>
> Cc: hch@infradead.org, xfs@oss.sgi.com
> Sent: Tuesday, August 4, 2015 10:46:25 AM
> Subject: Re: [PATCH v3 04/11] xfsprogs: Add ifdef dirent checks where it was missing
>
> > diff --git a/io/readdir.c b/io/readdir.c
> > index 20b8898..ed8f04d 100644
> > --- a/io/readdir.c
> > +++ b/io/readdir.c
> > @@ -104,12 +104,16 @@ read_directory(
> > if (!dirent)
> > break;
> >
> > +#ifdef _DIRENT_HAVE_D_RECLEN
> > *total += dirent->d_reclen;
> > +#endif
>
> You probably want to use d_namen + sizeof(*dirent) to approimate
> the value if d_reclen doesn't exist.
>
> > count++;
> >
> > if (dump) {
> > dump_dirent(offset, dirent);
> > +#ifdef _DIRENT_HAVE_D_OFF
> > offset = dirent->d_off;
> > +#endif
>
> We're only using the offset for dumping the value, maybe setting
> it to 0 and adding a comment explaining it should go into the else
> branch here?
>

That sounds reasonable, sending an updated patch.

Thanks. :-)

Jan

--
Jan Tulak
jtulak@redhat.com