Re: [PATCH 05/11] xfs: use EFI refcount consistently in log recovery

Brian Foster
2015-08-10T12:37:59Z

On Sun, Aug 09, 2015 at 12:56:40AM -0700, Christoph Hellwig wrote:
> > + error = xfs_efi_copy_format(&(item->ri_buf[0]), &(efip->efi_format));
> > + if (error) {
> > xfs_efi_item_free(efip);
>
> Shou;dn't we switch all users of xfs_item_free except for
> xfs_efi_release to xfs_efi_release now for consistency?
>

I don't think that's necessarily correct, at least as a one-to-one
conversion. We'd have to release two references here as well as in the
unlock handler if the transaction is aborted.

E.g., the reference count is only relevant once the EFI enters the
transaction subsystem.

Brian

> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs