[PATCH 00/11] xfs: miscellaneous logging, recovery, umount fixes

Brian Foster
2015-08-06T17:44:37Z

Hi all,

This series includes a bunch of bug fixes from doing some log recovery
testing. It started with an RFC of the EFI/EFD bits and expanded to
include more fixes as problems were discovered.

Patch 1 removes the superfluous EFI/EFD extent count reference tracking.
Patches 2-6 make a couple cleanups and fix the explicit EFI/EFD
reference counting to avoid leaving EFI items on the AIL in the event of
error. Patches 7-8 fix handling of cancelled icreate transactions in log
recovery. Patch 9 is a repost of a previous log recovery fix. Patches
10-11 fix a couple more mount related crash/hang issues.

Just about all of these problems were reproduced by running repeated
fsstress/godown workloads against XFS. This set has gone ~150 iterations
of said testing before hitting some kind of recovery time directory
corruption in the form of a dir. block write verifier failure. I'll see
if it is reproducible, but I don't think it's related to anything
here since I haven't touched directory code...

Brian

v1:
- Updated EFI/EFD tracking semantics based on rfc comments.
- Added more cleanups/fixes to series.
rfc: http://oss.sgi.com/pipermail/xfs/2015-July/042617.html

Brian Foster (11):
xfs: disentagle EFI release from the extent count
xfs: return committed status from xfs_trans_roll()
xfs: fix efi/efd error handling to avoid fs shutdown hangs
xfs: ensure EFD trans aborts on log recovery extent free failure
xfs: use EFI refcount consistently in log recovery
xfs: don't leave EFIs on AIL on mount failure
xfs: icreate log item recovery and cancellation tracepoints
xfs: fix broken icreate log item cancellation
xfs: checksum log record ext headers based on record size
xfs: clean up root inode properly on mount failure
xfs: fix btree cursor error cleanups

fs/xfs/libxfs/xfs_ialloc.c | 2 +-
fs/xfs/xfs_bmap_util.c | 84 +++++++++++++++-----------
fs/xfs/xfs_extfree_item.c | 118 +++++++++++++++++-------------------
fs/xfs/xfs_extfree_item.h | 1 +
fs/xfs/xfs_itable.c | 3 +-
fs/xfs/xfs_log.c | 23 +++++--
fs/xfs/xfs_log.h | 2 +-
fs/xfs/xfs_log_priv.h | 2 +
fs/xfs/xfs_log_recover.c | 147 +++++++++++++++++++++++++++++++++------------
fs/xfs/xfs_mount.c | 37 ++++++++----
fs/xfs/xfs_trace.h | 34 +++++++++++
fs/xfs/xfs_trans.c | 15 ++++-
fs/xfs/xfs_trans.h | 2 +-
13 files changed, 307 insertions(+), 163 deletions(-)

--
2.1.0