* [PATCH] xfs: add mssing inode cache attempts counter increment
@ 2015-08-27 19:04 Lucas Stach
2015-08-31 18:19 ` Brian Foster
0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2015-08-27 19:04 UTC (permalink / raw)
To: Dave Chinner; +Cc: xfs
Increasing the inode cache attempt counter was apparently dropped while
refactoring the cache code and so stayed at the initial 0 value. Add the
increment back to make the runtime stats more useful.
Signed-off-by: Lucas Stach <dev@lynxeye.de>
---
fs/xfs/xfs_icache.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 76a9f27..0a326bd 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -412,6 +412,8 @@ xfs_iget(
if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount)
return -EINVAL;
+ XFS_STATS_INC(xs_ig_attempts);
+
/* get the perag structure and ensure that it's inode capable */
pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino));
agino = XFS_INO_TO_AGINO(mp, ino);
--
2.4.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs: add mssing inode cache attempts counter increment
2015-08-27 19:04 [PATCH] xfs: add mssing inode cache attempts counter increment Lucas Stach
@ 2015-08-31 18:19 ` Brian Foster
0 siblings, 0 replies; 2+ messages in thread
From: Brian Foster @ 2015-08-31 18:19 UTC (permalink / raw)
To: Lucas Stach; +Cc: xfs
On Thu, Aug 27, 2015 at 09:04:21PM +0200, Lucas Stach wrote:
> Increasing the inode cache attempt counter was apparently dropped while
> refactoring the cache code and so stayed at the initial 0 value. Add the
> increment back to make the runtime stats more useful.
>
> Signed-off-by: Lucas Stach <dev@lynxeye.de>
> ---
Heh, this goes back to:
bf90424 [XFS] Combine the XFS and Linux inodes
... from 2008. :)
Reviewed-by: Brian Foster <bfoster@redhat.com>
> fs/xfs/xfs_icache.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 76a9f27..0a326bd 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -412,6 +412,8 @@ xfs_iget(
> if (!ino || XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount)
> return -EINVAL;
>
> + XFS_STATS_INC(xs_ig_attempts);
> +
> /* get the perag structure and ensure that it's inode capable */
> pag = xfs_perag_get(mp, XFS_INO_TO_AGNO(mp, ino));
> agino = XFS_INO_TO_AGINO(mp, ino);
> --
> 2.4.3
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-31 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 19:04 [PATCH] xfs: add mssing inode cache attempts counter increment Lucas Stach
2015-08-31 18:19 ` Brian Foster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox