Re: [PATCH v13 12/51] vfs: Cache richacl in struct inode

Andreas Gruenbacher
2015-11-04T22:10:49Z

Andreas,

On Wed, Nov 4, 2015 at 3:03 AM, Andreas Dilger <adilger@dilger.ca> wrote:
>> @@ -33,7 +33,7 @@ richacl_alloc(int count, gfp_t gfp)
>> struct richacl *acl = kzalloc(size, gfp);
>>
>> if (acl) {
>> - atomic_set(&acl->a_refcount, 1);
>> + atomic_set(&acl->a_base.ba_refcount, 1);
>> acl->a_count = count;
>> }
>> return acl;
>> @@ -52,7 +52,7 @@ richacl_clone(const struct richacl *acl, gfp_t gfp)
>>
>> if (dup) {
>> memcpy(dup, acl, size);
>> - atomic_set(&dup->a_refcount, 1);
>> + atomic_set(&dup->a_base.ba_refcount, 1);
>
> These two calls should be base_acl_init().

Yes. This should all be fixed in the next snapshot.

Thanks,
Andreas