From: Christoph Hellwig <hch@lst.de>
To: darrick.wong@oracle.com
Cc: xfs@oss.sgi.com
Subject: [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend
Date: Sun, 3 Jan 2016 13:07:53 +0100 [thread overview]
Message-ID: <1451822873-12969-4-git-send-email-hch@lst.de> (raw)
In-Reply-To: <1451822873-12969-1-git-send-email-hch@lst.de>
Otherwise we leak COW allocations done earlier in writepage. This
can be reproduced fairly easily when we hit the non-blocking writeback
EAGAIN case.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
fs/xfs/xfs_aops.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 185415a..9c69dc3 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -588,6 +588,7 @@ xfs_cancel_ioend(
{
xfs_ioend_t *next;
struct buffer_head *bh, *next_bh;
+ int error;
do {
next = ioend->io_list;
@@ -605,6 +606,12 @@ xfs_cancel_ioend(
unlock_buffer(bh);
} while ((bh = next_bh) != NULL);
+ if (ioend->io_flags & XFS_IOEND_COW) {
+ error = xfs_reflink_end_cow_failed(
+ XFS_I(ioend->io_inode),
+ ioend->io_offset, ioend->io_size);
+ WARN_ON_ONCE(error);
+ }
mempool_free(ioend, xfs_ioend_pool);
} while ((ioend = next) != NULL);
}
--
1.9.1
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-01-03 12:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 12:07 reflink fixes Christoph Hellwig
2016-01-03 12:07 ` [PATCH 1/3] xfs: pass inode instead of file to xfs_reflink_dirty_range Christoph Hellwig
2016-01-05 1:23 ` Darrick J. Wong
2016-01-03 12:07 ` [PATCH 2/3] xfs: only end a COW operation in xfs_zero_remaining_bytes if we started one Christoph Hellwig
2016-01-05 1:28 ` Darrick J. Wong
2016-01-03 12:07 ` Christoph Hellwig [this message]
2016-01-05 1:43 ` [PATCH 3/3] xfs: cancel COW in xfs_cancel_ioend Darrick J. Wong
2016-01-05 10:42 ` Christoph Hellwig
2016-01-07 0:32 ` Darrick J. Wong
2016-01-07 15:25 ` Christoph Hellwig
2016-01-08 10:09 ` Darrick J. Wong
2016-01-08 13:47 ` Christoph Hellwig
2016-01-09 21:17 ` Darrick J. Wong
2016-01-10 7:54 ` Christoph Hellwig
2016-01-10 22:48 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451822873-12969-4-git-send-email-hch@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox