Re: [dm-devel] [PATCH 02/35] block: add REQ_OP definitions and bi_op/op fields

Mike Christie
2016-01-10T00:57:03Z

On 01/09/2016 07:37 AM, Christoph Hellwig wrote:
> Seems like this is missing REQ_OP_FLUSH, which still hides as a write?
>

I might have misunderstood what you wanted or am misunderstanding you now.

I did not change the flush related code until the last patches. I added
REQ_OP_FLUSH in patch:

[PATCH 33/35] block, drivers: add REQ_OP_FLUSH operation
commit 18dea20363ba245a47bc1bb54f6465b8a05b19af
Author: Mike Christie <mchristi@redhat.com>
Date: Tue Jan 5 21:02:17 2016 -0600

block, drivers: add REQ_OP_FLUSH operation

and I added the REQ_PREFLUSH flag in

[PATCH 35/35] block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH
commit 303dc6a7cc3673065538ba041562fcd833a619af
Author: Mike Christie <mchristi@redhat.com>
Date: Thu Jan 7 18:17:03 2016 -0600

block, drivers, fs: rename REQ_FLUSH to REQ_PREFLUSH

I did them in separate patches, because I was not sure if they were
correct with what you requested before, and because they were a little
more tricky because of how request_fn drivers, make_request_fn drivers,
and dm-multipath handle flushes differently.