From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 0/2 v3] xfs: handle dquot buffer readahead in log recovery correctly
Date: Mon, 11 Jan 2016 14:24:52 +1100 [thread overview]
Message-ID: <1452482694-27314-1-git-send-email-david@fromorbit.com> (raw)
Hi folks,
Version 3 of this patchset. Version 2 of the patchset added a fix
for the inode readahead error setting in log recovery, which turned
out to be problematic.
I've split that change out into it's own patch which includes the
fix it requires to prevent a race condition in log recovery to do
with inode buffer creation recovery. This is a generic fix to
xfs_buf_get_map(), in that if we are returning an initialised buffer
for the caller to use, it shouldn't have an error set on it from the
previous operation. If we don't clear the error before returning the
buffer, it causes unexpected failures further down the line. This
caused log recovery failures in generic/073 on slow disks (i.e.
needed sufficient readahead IO latency to open the race window) and
a couple of other tests as well.
The second patch is essentially the original patch with just the
inode buffer changes removed. There are no other changes to that
patch.
Cheers,
Dave.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-01-11 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 3:24 Dave Chinner [this message]
2016-01-11 3:24 ` [PATCH 1/2] xfs: inode recovery readahead can race with inode buffer creation Dave Chinner
2016-01-11 16:03 ` Brian Foster
2016-01-11 3:24 ` [PATCH 2/2] xfs: handle dquot buffer readahead in log recovery correctly Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452482694-27314-1-git-send-email-david@fromorbit.com \
--to=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox