From: Brian Foster <bfoster@redhat.com>
To: xfs@oss.sgi.com
Subject: [PATCH v3 0/4] fix up indlen reservations on extent split
Date: Fri, 4 Mar 2016 09:40:27 -0500 [thread overview]
Message-ID: <1457102431-5215-1-git-send-email-bfoster@redhat.com> (raw)
Hi all,
Here's v3 of the delalloc indlen reservation fix. This version
incorporates Christoph's review feedback from v2. The test
instrumentation patch is updated to better compile out bits in !DEBUG
mode and patch 3/3 from v2 is split into two patches. The first
refactors the code and creates the new helper. The second updates the
mechanism to implement block borrowing from the data extent.
As a note, I investigated burying the DEBUG mode stuff down in
xfs_get_blocks(). The hope was that we could artificially mark the
buffers as new to maintain the aggressive block tossing behavior, but as
it turns out, the buffer_new() state is not returned out of that
context. __block_write_begin() zeroes and clears any new buffers in the
event of an error. This does raise the question of how relevant the
buffer_new() checks are in xfs_vm_write_failed(), but that's a separate
issue.
Thoughts, reviews, flames appreciated.
Brian
v3:
- Drop RFC from test instrumentation patch.
- Update test instrumentation patch to use inline helper and compile
more out in !DEBUG mode.
- Split block borrowing patch into 2 patches.
v2: http://oss.sgi.com/pipermail/xfs/2016-February/047300.html
- Rebase to latest for-next branch.
- Include RFC test instrumentation patch.
v1: http://oss.sgi.com/archives/xfs/2014-10/msg00294.html
- xfs_bunmapi() code into independent patch.
- Refactor fix into separate helper function.
rfc: http://oss.sgi.com/archives/xfs/2014-09/msg00337.html
Brian Foster (4):
xfs: debug mode forced buffered write failure
xfs: update freeblocks counter after extent deletion
xfs: refactor delalloc indlen reservation split into helper
xfs: borrow indirect blocks from freed extent when available
fs/xfs/libxfs/xfs_bmap.c | 161 ++++++++++++++++++++++++++++++++++-------------
fs/xfs/xfs_aops.c | 9 ++-
fs/xfs/xfs_mount.h | 25 ++++++++
fs/xfs/xfs_sysfs.c | 78 ++++++++++++++++++++---
4 files changed, 219 insertions(+), 54 deletions(-)
--
2.4.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2016-03-04 14:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 14:40 Brian Foster [this message]
2016-03-04 14:40 ` [PATCH 1/4] xfs: debug mode forced buffered write failure Brian Foster
2016-03-05 18:27 ` Christoph Hellwig
2016-03-04 14:40 ` [PATCH 2/4] xfs: update freeblocks counter after extent deletion Brian Foster
2016-03-04 14:40 ` [PATCH 3/4] xfs: refactor delalloc indlen reservation split into helper Brian Foster
2016-03-04 14:40 ` [PATCH 4/4] xfs: borrow indirect blocks from freed extent when available Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457102431-5215-1-git-send-email-bfoster@redhat.com \
--to=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox