public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: xfs@oss.sgi.com
Subject: [PATCH 2/6] xfs: ioends require logically contiguous file offsets
Date: Mon,  7 Mar 2016 08:49:46 +1100	[thread overview]
Message-ID: <1457300990-18300-3-git-send-email-david@fromorbit.com> (raw)
In-Reply-To: <1457300990-18300-1-git-send-email-david@fromorbit.com>

From: "Darrick J. Wong" <darrick.wong@oracle.com>

We need to create a new ioend if the current writepage call isn't
logically contiguous with the range contained in the previous ioend.
Hopefully writepage gets called in order of increasing file offset.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
 fs/xfs/xfs_aops.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
index 7a467b3..75a39a8 100644
--- a/fs/xfs/xfs_aops.c
+++ b/fs/xfs/xfs_aops.c
@@ -526,7 +526,8 @@ xfs_add_to_ioend(
 	struct list_head	*iolist)
 {
 	if (!wpc->ioend || wpc->io_type != wpc->ioend->io_type ||
-	    bh->b_blocknr != wpc->last_block + 1) {
+	    bh->b_blocknr != wpc->last_block + 1 ||
+	    offset != wpc->ioend->io_offset + wpc->ioend->io_size) {
 		struct xfs_ioend	*new;
 
 		if (wpc->ioend)
-- 
2.7.0

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2016-03-06 21:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-06 21:49 [PATCH 0/6] xfs: accumulated fixes for 4.6 Dave Chinner
2016-03-06 21:49 ` [PATCH 1/6] xfs: reinitialise per-AG structures if geometry changes during recovery Dave Chinner
2016-03-07 16:24   ` Christoph Hellwig
2016-03-06 21:49 ` Dave Chinner [this message]
2016-03-07 16:26   ` [PATCH 2/6] xfs: ioends require logically contiguous file offsets Christoph Hellwig
2016-03-08  2:33     ` Darrick J. Wong
2016-03-08  7:01       ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 3/6] xfs: fix computation of inode btree maxlevels Dave Chinner
2016-03-06 21:49 ` [PATCH 4/6] xfs: use named array initializers for log item dumping Dave Chinner
2016-03-07 16:27   ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 5/6] xfs: check sizes of XFS on-disk structures at compile time Dave Chinner
2016-03-07 16:27   ` Christoph Hellwig
2016-03-06 21:49 ` [PATCH 6/6] xfs: pad xfs_attr_leaf_name_remote to avoid tripping on m68k Dave Chinner
2016-03-07 16:28   ` Christoph Hellwig
2016-03-08  3:56     ` Dave Chinner
2016-03-08  7:02       ` Christoph Hellwig
2016-03-08 17:34     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1457300990-18300-3-git-send-email-david@fromorbit.com \
    --to=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox